[PATCH 5/5] spidernet: revise link status logging

Previous thread: Re: 2.6.25-rc8: FTP transfer errors by Mark Lord on Thursday, April 10, 2008 - 8:16 pm. (121 messages)

Next thread: [PATCH 1/5] spidernet: add missing initialization by Ishizaki Kou on Thursday, April 10, 2008 - 11:27 pm. (2 messages)
To: <jgarzik@...>
Cc: <jens@...>, <netdev@...>, <cbe-oss-dev@...>
Date: Thursday, April 10, 2008 - 11:33 pm

This patch revises the logging for link informations of spidernet.

- The link down message is too verbose because auto-negotiation timeout
occurs periodically while an ethernet cable is not connected.
- We want to see the link result, and we think it should be displayed.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
---

Index: linux-powerpc-git/drivers/net/spider_net.c
===================================================================
--- linux-powerpc-git.orig/drivers/net/spider_net.c
+++ linux-powerpc-git/drivers/net/spider_net.c
@@ -2045,7 +2045,8 @@ static void spider_net_link_phy(unsigned
/* if link didn't come up after SPIDER_NET_ANEG_TIMEOUT tries, setup phy again */
if (card->aneg_count > SPIDER_NET_ANEG_TIMEOUT) {

- pr_info("%s: link is down trying to bring it up\n", card->netdev->name);
+ pr_debug("%s: link is down trying to bring it up\n",
+ card->netdev->name);

switch (card->medium) {
case BCM54XX_COPPER:
@@ -2096,9 +2097,10 @@ static void spider_net_link_phy(unsigned

card->aneg_count = 0;

- pr_debug("Found %s with %i Mbps, %s-duplex %sautoneg.\n",
- phy->def->name, phy->speed, phy->duplex==1 ? "Full" : "Half",
- phy->autoneg==1 ? "" : "no ");
+ pr_info("%s: link up, %i Mbps, %s-duplex %sautoneg.\n",
+ card->netdev->name, phy->speed,
+ phy->duplex == 1 ? "Full" : "Half",
+ phy->autoneg == 1 ? "" : "no ");

return;
}
--

Previous thread: Re: 2.6.25-rc8: FTP transfer errors by Mark Lord on Thursday, April 10, 2008 - 8:16 pm. (121 messages)

Next thread: [PATCH 1/5] spidernet: add missing initialization by Ishizaki Kou on Thursday, April 10, 2008 - 11:27 pm. (2 messages)