Re: kernel 2.6.25-rc7 highly unstable on high load

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Denys Fedoryshchenko <denys@...>
Cc: Stephen Hemminger <stephen.hemminger@...>, <netdev@...>, <netfilter-devel@...>
Date: Friday, March 28, 2008 - 5:17 pm

Denys Fedoryshchenko a écrit :

Yes, the fix is the patch we mentioned yesterday, and you told us you tried it :(

commit 7c0ecc4c4f8fd90988aab8a95297b9c0038b6160

[ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).

Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
relookup support) introduced some dst leaks on error paths: the rt
pointer can be forgotten to be put. Fix it bu going to a proper label.

Found after net namespace's lo refused to unregister :) Many thanks to
Den for valuable help during debugging.

Herbert pointed out, that xfrm_lookup() will put the rtable in case
of error itself, so the first goto fix is redundant.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Thu Mar 27, 12:07 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Thu Mar 27, 2:37 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Thu Mar 27, 2:56 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, David Miller, (Thu Mar 27, 6:03 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Fri Mar 28, 1:25 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Fri Mar 28, 1:49 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Fri Mar 28, 3:38 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Fri Mar 28, 3:46 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Fri Mar 28, 11:57 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Stephen Hemminger, (Fri Mar 28, 4:23 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Fri Mar 28, 4:45 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Fri Mar 28, 5:17 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, David Miller, (Fri Mar 28, 7:21 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Sat Mar 29, 5:35 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Fri Mar 28, 5:50 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Fri Mar 28, 12:50 am)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denys Fedoryshchenko, (Thu Mar 27, 8:47 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Denis V. Lunev, (Thu Mar 27, 3:05 pm)
Re: kernel 2.6.25-rc7 highly unstable on high load, Eric Dumazet, (Thu Mar 27, 12:29 pm)