RE: [PATCH] e1000e: test MSI interrupts

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kok, Auke-jan H <auke-jan.h.kok@...>, Jeff Garzik <jeff@...>
Cc: <e1000-devel@...>, <netdev@...>
Date: Thursday, March 27, 2008 - 1:53 pm

Kok, Auke wrote:


Actually, I'm hoping you'll allow this Jeff, we have a production system
(see below) we know about that doesn't like the way 82571 formats MSI
interrupt messages.  All other systems seem to be okay with this format
of MSI messages, but this system implemented a stricter interpretation
of the spec, and so even though that system doesn't need a quirk for MSI
because MSI works in general, we still MUST test the MSI vector to make
sure it works *for us*  In this case it comes down to being an errata
workaround.

Since there is no way to "test" generation of an interrupt from any
specific hardware device without internal knowledge of said device,
there isn't a way for us to help the kernel by writing a generic "test
MSI" routine.

I would prefer this "generic test" code be in the driver rather than
having to identify all the chipsets that fail and have the driver do
*specific chipset* detection ala bnx2.c's 8132 bridge workaround.


This is our workaround, it is our fault, the incompatible chipset is in
an x3850 IBM system.


We had avoided this test in the past based on your recommendation but in
this case I don't see a way around it, do you?  I'm open to other
suggestions but we need to solve the problem somehow in an *automated*
way.  IBM requested we do it this way.
 
Jesse
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] e1000e: test MSI interrupts, Auke Kok, (Wed Mar 26, 2:36 pm)
Re: [PATCH] e1000e: test MSI interrupts, Jeff Garzik, (Wed Mar 26, 2:42 pm)
RE: [PATCH] e1000e: test MSI interrupts, Brandeburg, Jesse, (Thu Mar 27, 1:53 pm)
Re: [PATCH] e1000e: test MSI interrupts, Andy Gospodarek, (Thu Mar 27, 6:05 pm)
Re: [PATCH] e1000e: test MSI interrupts, Kok, Auke, (Thu Mar 27, 6:16 pm)
Re: [PATCH] e1000e: test MSI interrupts, Andy Gospodarek, (Thu Mar 27, 6:33 pm)
Re: [PATCH] e1000e: test MSI interrupts, Kok, Auke, (Thu Mar 27, 6:47 pm)
Re: [PATCH] e1000e: test MSI interrupts, David Miller, (Thu Mar 27, 5:59 pm)
Re: [PATCH] e1000e: test MSI interrupts, Jeff Garzik, (Thu Mar 27, 3:43 pm)
Re: [PATCH] e1000e: test MSI interrupts, David Miller, (Thu Mar 27, 6:05 pm)
RE: [PATCH] e1000e: test MSI interrupts, Brandeburg, Jesse, (Thu Mar 27, 6:55 pm)
Re: [PATCH] e1000e: test MSI interrupts, Jeff Garzik, (Thu Mar 27, 7:38 pm)
Re: [PATCH] e1000e: test MSI interrupts, Kok, Auke, (Thu Mar 27, 7:53 pm)
Re: [PATCH] e1000e: test MSI interrupts, David Miller, (Thu Mar 27, 8:03 pm)
Re: [PATCH] e1000e: test MSI interrupts, David Miller, (Thu Mar 27, 7:06 pm)