Home » Mailing list archives » linux-netdev » 2008 » March » 27

[PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Sebastian Siewior <bigeasy@...>
To: <uclinux-dev@...>
Cc: <netdev@...>, Jeff Garzik <jgarzik@...>, Greg Ungerer <gerg@...>
Subject: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver
Date: Thursday, March 27, 2008 - 10:00 am

I got into this after turning on spinlock debugging.

Jeff: The dev->hard_start_xmit callback is always called from softirq
context so it is save to use spin_lock_irq(), right?

Greg: The isr (fec_enet_rx()) calls three functions. All
but fec_enet_rx() are grabbing the spinlock. Is this on purpose?

Sebastian
-- 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver, Sebastian Siewior, (Thu Mar 27, 10:00 am)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Jeff Garzik, (Fri Mar 28, 10:21 pm)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Sebastian Siewior, (Wed Apr 2, 7:11 am)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Jeff Garzik, (Fri Mar 28, 10:19 pm)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Greg Ungerer, (Fri Mar 28, 2:51 am)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Sebastian Siewior, (Wed Apr 2, 7:28 am)
Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu dri..., Greg Ungerer, (Wed Apr 2, 8:50 am)