Home » Mailing list archives » linux-netdev » 2008 » March » 27

[PATCH 2/6 net-2.6.26] [UDP]: No need to check afinfo != NULL in udp_proc_(un)register.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Denis V. Lunev <den@...>
To: <davem@...>
Cc: <netdev@...>, Denis V. Lunev <den@...>
Subject: [PATCH 2/6 net-2.6.26] [UDP]: No need to check afinfo != NULL in udp_proc_(un)register.
Date: Thursday, March 27, 2008 - 10:11 am

udp_proc_register/udp_proc_unregister are called with a static pointer only.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 net/ipv4/udp.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 6d740ad..c05f45b 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1631,8 +1631,6 @@ int udp_proc_register(struct net *net, struct udp_seq_afinfo *afinfo)
 	struct proc_dir_entry *p;
 	int rc = 0;
 
-	if (!afinfo)
-		return -EINVAL;
 	afinfo->seq_fops->owner		= afinfo->owner;
 	afinfo->seq_fops->open		= udp_seq_open;
 	afinfo->seq_fops->read		= seq_read;
@@ -1649,8 +1647,6 @@ int udp_proc_register(struct net *net, struct udp_seq_afinfo *afinfo)
 
 void udp_proc_unregister(struct net *net, struct udp_seq_afinfo *afinfo)
 {
-	if (!afinfo)
-		return;
 	proc_net_remove(net, afinfo->name);
 	memset(afinfo->seq_fops, 0, sizeof(*afinfo->seq_fops));
 }
-- 
1.5.3.rc5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/6 net-2.6.26] [UDP]: udp_proc_register simplificati..., Denis V. Lunev, (Thu Mar 27, 10:10 am)
Re: [PATCH 0/6 net-2.6.26] [UDP]: udp_proc_register simplifi..., David Miller, (Fri Mar 28, 9:26 pm)
[PATCH 4/6 net-2.6.26] [UDP]: Cleanup /proc/udp[6] creation/..., Denis V. Lunev, (Thu Mar 27, 10:11 am)
[PATCH 3/6 net-2.6.26] [UDP]: Move seq_ops from udp_iter_sta..., Denis V. Lunev, (Thu Mar 27, 10:11 am)
[PATCH 1/6 net-2.6.26] [UDP]: Replace struct net on udp_iter..., Denis V. Lunev, (Thu Mar 27, 10:11 am)
[PATCH 2/6 net-2.6.26] [UDP]: No need to check afinfo != NUL..., Denis V. Lunev, (Thu Mar 27, 10:11 am)
[PATCH 5/6 net-2.6.26] [UDP]: Place file operations directly..., Denis V. Lunev, (Thu Mar 27, 10:11 am)
[PATCH 6/6 net-2.6.26] [UDP]: Remove owner from udp_seq_afin..., Denis V. Lunev, (Thu Mar 27, 10:11 am)