Home » Mailing list archives » linux-netdev » 2008 » March » 21

[PATCH] Fix null dereference in ip_defrag

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Phil Oester <kernel@...>
To: <netdev@...>
Subject: [PATCH] Fix null dereference in ip_defrag
Date: Friday, March 21, 2008 - 3:09 pm

Been seeing occasional panics in my testing of 2.6.25-rc in ip_defrag.
Offending line in ip_defrag is here:

	net = skb->dev->nd_net

where dev is NULL.  Bisected the problem down to commit
ac18e7509e7df327e30d6e073a787d922eaf211d ([NETNS][FRAGS]: Make the
inet_frag_queue lookup work in namespaces).  

Below patch (idea from Patrick McHardy) fixes the problem for me.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Acked-by: Patrick McHardy <kaber@trash.net>

Phil
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix null dereference in ip_defrag, Phil Oester, (Fri Mar 21, 3:09 pm)
Re: [PATCH] Fix null dereference in ip_defrag, David Miller, (Fri Mar 21, 6:00 pm)