[PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale.

Previous thread: Re: oops with ipcomp by Beschorner Daniel on Wednesday, February 6, 2008 - 7:43 am. (8 messages)

Next thread: [patch 0/4] s390: ctc patches for 2.6.25 (3rd try) by Ursula Braun on Wednesday, February 6, 2008 - 11:27 am. (1 message)
From: Steve Wise
Date: Wednesday, February 6, 2008 - 11:05 am

cxgb3: Handle ARP completions that mark neighbors stale.

When ARP completes due to a request rather than a reply the neighbor is
marked NUD_STALE instead of reachable (see arp_process()).  The handler
for the resulting netevent needs to check also for NUD_STALE.

Failure to use the arp entry can cause RDMA connection failures.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/net/cxgb3/l2t.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/cxgb3/l2t.c b/drivers/net/cxgb3/l2t.c
index d660af7..d80bbdb 100644
--- a/drivers/net/cxgb3/l2t.c
+++ b/drivers/net/cxgb3/l2t.c
@@ -404,7 +404,7 @@ found:
 			if (neigh->nud_state & NUD_FAILED) {
 				arpq = e->arpq_head;
 				e->arpq_head = e->arpq_tail = NULL;
-			} else if (neigh_is_connected(neigh))
+			} else if (neigh->nud_state & (NUD_CONNECTED|NUD_STALE))
 				setup_l2e_send_pending(dev, NULL, e);
 		} else {
 			e->state = neigh_is_connected(neigh) ?
--

From: Divy Le Ray
Date: Wednesday, February 6, 2008 - 11:27 am

Acked-by: Divy Le Ray <divy@chelsio.com>

Divy
--

From: Jeff Garzik
Date: Monday, February 11, 2008 - 9:09 am

applied


--

Previous thread: Re: oops with ipcomp by Beschorner Daniel on Wednesday, February 6, 2008 - 7:43 am. (8 messages)

Next thread: [patch 0/4] s390: ctc patches for 2.6.25 (3rd try) by Ursula Braun on Wednesday, February 6, 2008 - 11:27 am. (1 message)