Home » Mailing list archives » linux-netdev » 2008 » February » 21

[PATCH] Fix multicast on VLAN interfaces

Previous thread: [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx() by Eric Dumazet on Thursday, February 21, 2008 - 11:51 am. (35 messages)

Next thread: none
[view original message]
From: Phil Oester
Subject: [PATCH] Fix multicast on VLAN interfaces
Date: Thursday, February 21, 2008 - 3:05 pm

In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list
handling was reworked.  Unfortunately, a variable initialization was missed,
and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently
not too many people use this).  Trivial fix below, which might be a candidate
for -stable.

Phil

Signed-off-by: Phil Oester <kernel@linuxace.com>


[ message continues ]
[view original message]
From: Patrick McHardy
Subject: Re: [PATCH] Fix multicast on VLAN interfaces
Date: Friday, February 22, 2008 - 5:25 am

Thanks Phil, a similar patch is already sitting in net-2.6.git.
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] Fix multicast on VLAN interfaces
Date: Saturday, February 23, 2008 - 9:00 pm

From: Phil Oester <kernel@linuxace.com>

"da" is kzalloc()'d, how can da->da_synced not be zero?
--


[ message continues ]
[view original message]
From: Phil Oester
Subject: Re: [PATCH] Fix multicast on VLAN interfaces
Date: Saturday, February 23, 2008 - 11:32 pm

Because it was originally kmalloc'd, not kzalloc'd.  It was
fixed about 2 days prior to my patch submission, here:

    http://marc.info/?l=linux-netdev&m=120343348811767&w=2

which I missed.

Phil
--


[ message continues ]
Previous thread: [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx() by Eric Dumazet on Thursday, February 21, 2008 - 11:51 am. (35 messages)

Next thread: none