Home » Mailing list archives » linux-netdev » 2008 » February » 1

Re: [PATCH] Disable TSO for non standard qdiscs

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: jamal <hadi@...>
To: Patrick McHardy <kaber@...>
Cc: Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@...>, Andi Kleen <andi@...>, Glen Turner <gdt@...>, Stephen Hemminger <shemminger@...>, <netdev@...>
Subject: Re: [PATCH] Disable TSO for non standard qdiscs
Date: Friday, February 1, 2008 - 8:06 am

On Fri, 2008-01-02 at 10:56 +0100, Patrick McHardy wrote:


Right - Essentially it is a usability issue:
People who know how to use TSO (Peter for example) will be clueful
enough to turn it on. Which means the default should be to protect the
clueless and turn it off.
On Andis approach:
Turning TSO off at netdev registration time with a warning will be a
cleaner IMO. Or alternatively introducing a kernel-config "I know what
TSO is" option which is then used at netdev registration. From a
usability perspective it would make more sense to just keep ethtool as
the only way to configure TSO. 

[I recently spent a few days helping someone debug a problem with IFB
because he was redirecting packets from an TSO netdevice and occasionaly
some multi-packet will be missed in the calculation; my answer was "turn
off TSO"; so there are more use cases for this TSO issue]. 

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 8:46 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Rick Jones, (Thu Jan 31, 2:26 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 3:03 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Rick Jones, (Fri Feb 1, 5:58 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Sat Feb 2, 12:10 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Rick Jones, (Thu Jan 31, 2:35 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 3:25 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Rick Jones, (Thu Jan 31, 3:14 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Fri Feb 1, 12:31 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Herbert Xu, (Sat Feb 2, 6:59 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andy Furniss, (Thu Jan 31, 9:04 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Stephen Hemminger, (Thu Jan 31, 1:23 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 2:33 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Thu Jan 31, 2:01 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 2:37 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Stephen Hemminger, (Thu Jan 31, 2:08 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 2:53 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Herbert Xu, (Sat Feb 2, 6:57 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Sun Feb 3, 5:35 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Thu Jan 31, 2:21 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 3:01 pm)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Thu Jan 31, 2:47 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Thu Jan 31, 3:34 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Glen Turner, (Fri Feb 1, 2:35 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Fri Feb 1, 3:46 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Fri Feb 1, 3:25 am)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Fri Feb 1, 5:37 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Fri Feb 1, 10:34 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Stephen Hemminger, (Fri Feb 1, 1:24 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Fri Feb 1, 5:56 am)
Re: [PATCH] Disable TSO for non standard qdiscs, jamal, (Fri Feb 1, 8:06 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Sat Feb 2, 1:20 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Jarek Poplawski, (Fri Feb 1, 6:56 pm)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Fri Feb 1, 9:51 pm)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Fri Feb 1, 3:02 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Fri Feb 1, 2:46 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Jarek Poplawski, (Thu Jan 31, 4:33 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Fri Feb 1, 1:01 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Jarek Poplawski, (Thu Jan 31, 7:04 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Jarek Poplawski, (Fri Feb 1, 3:42 am)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Fri Feb 1, 5:28 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Jarek Poplawski, (Fri Feb 1, 5:47 pm)
RE: [PATCH] Disable TSO for non standard qdiscs, Waskiewicz Jr, Peter P, (Thu Jan 31, 3:39 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Arnaldo Carvalho de Melo, (Thu Jan 31, 7:10 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Andi Kleen, (Fri Feb 1, 12:36 am)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Thu Jan 31, 2:48 pm)
Re: [PATCH] Disable TSO for non standard qdiscs, Patrick McHardy, (Thu Jan 31, 2:11 pm)