There is a minor problem in iproute2 regarding the output of "ip -6 addr". Preferred lifetimes of IPv6 prefixes are printed as unsigned integers even though they may become negative (for deprecated prefixes). As I've argued in <http://bugzilla.kernel.org/show_bug.cgi?id=10880>, I think this is partly because of an inconsistency in the kernel APIs, but since nobody seemed interested, I guess it has to be dealt with by application developers. The following patch fixes the problem. --- ...

On Tue, 9 Dec 2008 12:03:37 +0100 yup. 2.6.27 needs fixing also. Like this? From: Andrew Morton <akpm@linux-foundation.org> ===================================== [ BUG: bad unlock balance detected! ] ------------------------------------- A regression added by 717d438d1fde94decef874b9808379d1f4523453 ("e1000e: debug contention on NVM SWFLAG"). Reported-by: "Zdenek Kabelac" <zdenek.kabelac@gmail.com> Cc: Frederik Deweerdt <frederik.deweerdt@xprog.eu> Cc: Thomas Gleixner ...

Sparse asked whether these could be static. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- net/decnet/dn_dev.c | 2 +- net/decnet/dn_route.c | 4 ++-- net/dsa/mv88e6060.c | 4 ++-- net/dsa/mv88e6123_61_65.c | 4 ++-- net/dsa/mv88e6131.c | 4 ++-- net/irda/irttp.c | 14 +++++++------- net/irda/timer.c | 2 +- ...

Use pr_debug() instead of own macros. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: bonding-2.6/drivers/net/bonding/bonding.h =================================================================== --- bonding-2.6.orig/drivers/net/bonding/bonding.h 2008-12-08 22:59:59.000000000 +0100 +++ bonding-2.6/drivers/net/bonding/bonding.h 2008-12-08 23:02:38.000000000 +0100 @@ -32,14 +32,6 @@ extern struct list_head bond_dev_list; -#ifdef BONDING_DEBUG -#define dprintk(fmt, ...

Remove some declarations from bonding.c as they are declared in bonding.h already. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: bonding-2.6/drivers/net/bonding/bond_sysfs.c =================================================================== --- bonding-2.6.orig/drivers/net/bonding/bond_sysfs.c 2008-12-05 23:21:10.000000000 +0100 +++ bonding-2.6/drivers/net/bonding/bond_sysfs.c 2008-12-05 23:23:12.000000000 +0100 @@ -43,15 +43,8 @@ /*---------------------------- ...

Use a small array in bond_mode_name() for the names, thus saving some space: before text data bss dec hex filename 57736 9372 344 67452 1077c drivers/net/bonding/bonding.ko after text data bss dec hex filename 57441 9372 344 67157 10655 drivers/net/bonding/bonding.ko Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: ...

This is what I get if debug is enabled: drivers/net/bonding/bond_ipv6.c: In function 'bond_na_send': drivers/net/bonding/bond_ipv6.c:75: error: 'slave' undeclared (first use in this function) drivers/net/bonding/bond_ipv6.c:75: error: (Each undeclared identifier is reported only once drivers/net/bonding/bond_ipv6.c:75: error: for each function it appears in.) This patch fixes that. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: ...

Should not be a problem. YouTube uses a single stream for buffering and there should not be any conflict between a change in source address with the request for the flash applet and the stream. HTTP does not work that way... There are some protocols that do, in which case there is contrac to solve that problem, if there were a bug it would be in contrac so you should raise the issue on the Netfilter lists. I have personally used Shorewall in such a configuration (we are designing a ...

Ben pointed out that he had sent this to me but not CCed the list, and that I'd missed it. I've worked through it now. That's just a spello on the mailing list subject line, the subject line I was replacing Andrew Victor's ks8695_ether driver, so the platform data is for ks8695_ether, but for a while I had both drivers in-tree in order to check behaviour. I am happy for it to be merged either as ks8695_ether or ks8695net and if necessary I can change the platform data for the boards. ...

The chip can strip CRC automatically on receiving. Enable it. Also fix potential RX_BUF_SIZE calculation bug which was obscured by alignment. And use proper symbols (NET_IP_ALIGN, ETH_FCS_LEN, etc.) instead of magic numbers. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- drivers/net/tc35815.c | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index 385b174..34a599d 100644 --- ...

Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/fwcmd_common_bmap.h | 717 +++++++++++++++++++++++++++++++++ drivers/net/benet/fwcmd_eth_bmap.h | 280 +++++++++++++ drivers/net/benet/fwcmd_opcodes.h | 244 +++++++++++ 3 files changed, 1241 insertions(+), 0 deletions(-) create mode 100644 drivers/net/benet/fwcmd_common_bmap.h create mode 100644 drivers/net/benet/fwcmd_eth_bmap.h create mode 100644 drivers/net/benet/fwcmd_opcodes.h diff --git ...

Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/Kconfig | 2 ++ drivers/net/Makefile | 1 + drivers/net/benet/Kconfig | 7 +++++++ drivers/net/benet/MAINTAINERS | 8 ++++++++ 4 files changed, 18 insertions(+), 0 deletions(-) create mode 100644 drivers/net/benet/Kconfig create mode 100644 drivers/net/benet/MAINTAINERS diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 231eeaf..85992af 100644 --- ...

Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/eth.c | 1273 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 1273 insertions(+), 0 deletions(-) create mode 100644 drivers/net/benet/eth.c diff --git a/drivers/net/benet/eth.c b/drivers/net/benet/eth.c new file mode 100644 index 0000000..f641b62 --- /dev/null +++ b/drivers/net/benet/eth.c @@ -0,0 +1,1273 @@ +/* + * Copyright (C) 2005 - 2008 ServerEngines + * All rights reserved. + * + * ...

Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/Makefile | 14 + drivers/net/benet/be_ethtool.c | 348 ++++++++++++++++ drivers/net/benet/be_int.c | 863 ++++++++++++++++++++++++++++++++++++++++ drivers/net/benet/be_netif.c | 707 ++++++++++++++++++++++++++++++++ 4 files changed, 1932 insertions(+), 0 deletions(-) create mode 100644 drivers/net/benet/Makefile create mode 100644 drivers/net/benet/be_ethtool.c create mode 100644 ...

Hi, the BladeEngine 10g NIC driver (benet) has undergone a few rounds of review on this list. Later, some more issues have been fixed as a part of the drivers/staging tree maintained by Greg KH. It is being re-submitted for a final round of review. The patches are against the torvalds git tree. Thanks, -Sathya P.S: Pls ignore the "company confidential" warning at the end of the patch emails. Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/be_init.c | 1382 ...

Signed-off-by: Sathya Perla <sathyap@serverengines.com> --- drivers/net/benet/bestatus.h | 103 ++++++ drivers/net/benet/hwlib.h | 830 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 933 insertions(+), 0 deletions(-) create mode 100644 drivers/net/benet/bestatus.h create mode 100644 drivers/net/benet/hwlib.h diff --git a/drivers/net/benet/bestatus.h b/drivers/net/benet/bestatus.h new file mode 100644 index 0000000..59c7a4b --- /dev/null +++ ...

[PATCH] simeth: convert to net_device_ops Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- arch/ia64/hp/sim/simeth.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) --- a/arch/ia64/hp/sim/simeth.c +++ b/arch/ia64/hp/sim/simeth.c @@ -167,6 +167,15 @@ netdev_read(int fd, unsigned char *buf, unsigned int len) return ia64_ssc(fd, __pa(buf), len, 0, SSC_NETDEV_RECV); } +static const struct net_device_ops simeth_netdev_ops = { + .ndo_open = ...

From: Wang Chen <wangchen@cn.fujitsu.com> Acked-by: Ursula Braun <ursula.braun@de.ibm.com> We run an additional test on our s390 box. Thanks! --

We can skip WARN_ON() in htb_dequeue_tree() because there should be always a similar warning from htb_lookup_leaf() earlier. The first WARN_ON() in in htb_lookup_leaf() is changed to BUG_ON() because most likly this should end with oops anyway. Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- net/sched/sch_htb.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index f44a4be..9de3682 100644 --- ...

Skip "event" in if () in htb_dequeue(): it's always > 0 at this place. Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- net/sched/sch_htb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index b241ac6..2e0a74c 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c @@ -879,7 +879,7 @@ static struct sk_buff *htb_dequeue(struct Qdisc *sch) } else event = q->near_ev_cache[level]; - if (event && ...

Currently htb_do_events() breaks events recounting for a level after 2 jiffies, but there is no reason to repeat this for next levels and increase delays even more (with softirqs disabled). htb_dequeue_tree() can add to this too, btw. In such a case q->now time is invalid anyway. Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- net/sched/sch_htb.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index ...

Sure. But it also won't be in the past if we simply add .. lets say the current uptime in ms. My point was that there's absolutely no relationship between those two times and combining them just to get a value thats not in the past is wrong. Especially considering *why* we want a value in the future and what we'll get from that htb_do_events() exceeding two jiffies is fortunately not a common case. You (incorrectly) made the calculation somewhat of a common case by also adding to the delay ...

This might as well return q->now, no? The elapsed time is added on top later anyways. But anyways, I think both the approach and the patch are wrong. /* charge used jiffies */ start_at = jiffies - start_at; if (start_at > 0) next_event += start_at * PSCHED_TICKS_PER_SEC / HZ; What relationship does the duration it ran for has to the time it should run at again? The focus on jiffies is wrong IMO, the reason why we get high load is because the CPU can't keep up, delaying things ...

The algorithm is we want to "continue on the next jiffie". We know we've lost here a lot of time (~2 jiffies), and this will be added later. Since these jiffies are not precise enough wrt. psched ticks or ktime, and we will add around 2000 (for HZ 1000) psched ticks anyway this +1 here simply doesn't matter and can mean "a bit after q->now". We can try to do this more precisely with additional psched_get_time(), instead of jiffies, but my "tests" didn't show any advantage. What matters is to ...

How about of every status change event? ie. a generic virtio_pci solution? Rusty. --

New status bits will screw this logic unless we count on the host not to set them. I suggest: /* Ignore unknown (future) status bits */ v &= VIRTIO_NET_S_LINK_UP; Cheers, Rusty. --

Next event time should consider jiffies used for recounting. Otherwise qdisc_watchdog_schedule() triggers hrtimer immediately with the event in the past, and may cause very high ksoftirqd cpu usage (if highres is on). Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- net/sched/sch_htb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index f89fd71..d6eb4a7 100644 --- a/net/sched/sch_htb.c +++ ...

From: Douglas Leith <doug.leith@nuim.ie> I remember asking you to -p1 root your patches last time, or did I? :-) --

1.When no interface is specified in an IPV6_PKTINFO ancillary data item, the interface specified in an IPV6_PKTINFO sticky optionis is used. RFC3542: 6.7. Summary of Outgoing Interface Selection This document and [RFC-3493] specify various methods that affect the selection of the packet's outgoing interface. This subsection summarizes the ordering among those in order to ensure deterministic behavior. For a given outgoing packet on a given socket, the outgoing ...

There are three reasons for me to add this support: 1.When no interface is specified in an IPV6_PKTINFO ancillary data item, the interface specified in an IPV6_PKTINFO sticky optionis is used. RFC3542: 6.7. Summary of Outgoing Interface Selection This document and [RFC-3493] specify various methods that affect the selection of the packet's outgoing interface. This subsection summarizes the ordering among those in order to ensure deterministic behavior. For a given ...

From: Rick Jones <rick.jones2@hp.com> All it takes is ~40 bytes on an extremely slow link. --

A miracle occurs going from zero bytes of payload but several bytes of TCP options (scale and MSS) to having one byte of payload and no bytes of options? (Timestamp options remaining the same in both cases) rick jones --

From: Alexey Dobriyan <adobriyan@gmail.com> Applied, thanks a lot Alexey. --

What happens? Does it oops, does one of the BUG() statements trigger? -- Manfred --

On Tue, 09 Dec 2008 20:16:34 +0100 It fails in strange ways, e.g. trying to open a DRM device causes it to disappear. (And DRM is a heavy user of idr.) --

From: Benjamin Thery <benjamin.thery@bull.net> Okie dokie. --

another new patch for net-next-2.6 --- From fbd6be20695810f32aa58a5cd889f959d87a019f Mon Sep 17 00:00:00 2001 From: Jianjun Kong <jianjun@zeuux.org> Date: Tue, 9 Dec 2008 09:23:54 +0800 Subject: [PATCH] net: Kill directly reference of netdev->priv drivers/net/wireless/ray_cs.c: Replace "(struct net_device *)link->priv" with "netdev_priv((struct net_device *)link)" Signed-off-by: Jianjun Kong <jianjun@zeuux.org> --- drivers/net/wireless/ray_cs.c | 12 ++++++------ 1 files changed, 6 ...

From: Denis Joseph Barrow <D.Barow@option.com> Alan, you got this one or want me to grab it? I'm fine either way. --

From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Applied. --

That one depends on the first patch though. -- Rémi Denis-Courmont Maemo Software, Nokia Devices R&D --

Uho :( I ended up not testing what I thought I was :-$ This patch deadlocks unregister_netdev(), since that waits for the refcount to drop to zero. -- Rémi Denis-Courmont Maemo Software, Nokia Devices R&D --

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- net/phonet/pep-gprs.c | 170 +++++++++++++++++++++++++------------------------ 1 files changed, 86 insertions(+), 84 deletions(-) diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c index a24d01e..7461a61 100644 --- a/net/phonet/pep-gprs.c +++ b/net/phonet/pep-gprs.c @@ -40,7 +40,7 @@ struct gprs_dev { void (*old_data_ready)(struct sock *, int); void (*old_write_space)(struct sock *); - struct ...

Matt, are you going to take care of this or do you want me to do that? Rafael --

From: "Matt Carlson" <mcarlson@broadcom.com> Ok, can someone post a patch that takes care of that against net-next-2.6? Thanks in advance! --

Hello, Attached is what I believe to be a reasonable final-cut of the driver. I believe I have addressed all the concerns raised by Ben Hutchings, Christoph Hellwig and David Miller. Assuming I have done so successfully, I'd like to request a merge of this version. Regards, Daniel. -- Daniel Silverstone http://www.simtec.co.uk/ PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895

Very well, I shall sort out an ammended patch. Thanks for your help in reviewing the code. Regards, Daniel. -- Daniel Silverstone http://www.simtec.co.uk/ PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895 --

Crypto needs 2 queues: 29 and 30. The numbers are fixed in the microcode, I think. Christian --

Hi Jesse, can you add this one, please. I adjusted the patch to suggestions from Matthew and Shaohua, thus added their Signed-offs. This should still go into .28 as it makes machines boot which now freeze since the ASPM patch was introduced. Thanks, Thomas ---- PCIe: ASPM: Break out of endless loop waiting for PCI config bits to switch Makes a Compaq 6735s boot reliably again which hang in the loop on some boots. Give the link one second to train, otherwise break out of ...

Ok, just pushed it. Thanks. Jesse --

From: Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de> Patch applied, thanks Hermann. --