On Mon, Dec 08, 2008 at 11:05:18AM +0000, Daniel Silverstone wrote:
quoted text
> > > +                       mapping = dma_map_single(ksp->dev, skb->data,
> > > +                                                MAX_RXBUF_SIZE,
> > > +                                                DMA_FROM_DEVICE);
> > I take it that dma_map_single() can never fail on ARM?
> 
> No it can't. It essentially boils down to some pointer arithmetic on
> this platform.

You should check for errors anyway.  The driver might be ported to an
architecture where it can fail (e.g. the SOC block gets reused), ARM
variants may come up where it can fail, or people might use the driver
as an example for their own new driver.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html