On Fri, Dec 26, 2008 at 01:45:37PM -0800, David Miller wrote:

quoted text
> > > -	skb = dev_alloc_skb(length);
> > > -	if (!skb) {
> > > +	skb = dev_alloc_skb(len);
> > > +	if (skb == NULL)
> > 
> > "!skb" is preferred to the long-winded "skb == NULL", so
> > I'm tossing this patch and the rest which touch similar
> > areas.
> 
> Also, I want to mention that your C++ comment conversions are not in
> the proper coding style as well.  You are doing:

As I'm currently offline most of the time I'll resend once I'm back
home.

Thanks for your feedback!

 /holger

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html