Re: [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Hannes Eder <hannes@...>

To: David Miller <davem@...>

Cc: <netdev@...>, <kernel-janitors@...>, <linux-kernel@...>

Subject: Re: [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression

Date: Friday, December 26, 2008 - 10:39 am

On Fri, Dec 26, 2008 at 1:17 AM, David Miller <davem@davemloft.net> wrote:
quoted text> From: Hannes Eder <hannes@hanneseder.net>
> Date: Mon, 22 Dec 2008 20:15:17 +0100
>
>> Fix this sparse warning:
>>
>>   drivers/net/niu.c:8850:2: warning: returning void-valued expression
>>
>> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
>
> Can we just fix sparse not to generate this warning?  It's
> marginal, at best.  C++ even explicitly defines this as valid
> and last time I brought this up Linus even agreed.
>
> The types match, the function returns void and it is returning a void,
> what is the problem?

after reading the following thread I decided to submit such type of patches:

On Thu, 1 May 2008 at 13:53:39 +0100, Al Viro wrote:
quoted text> On Thu, May 01, 2008 at 03:42:14PM +0300, Boaz Harrosh wrote:
> > > 3.  6.8.6.4(1): A return statement with an expression shall not appear in
> > > a function whose return type is void.
> > >
> >
> > Please forgive my ignorance, where is this quote from?
>
> C99.  I don't have C90 in front of me, so I can't give you exact quote from
> there, but it's been explicitly banned in C90 as well.

see http://lkml.org/lkml/2008/5/1/112
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/27] drivers/net: fix sparse warnings, Hannes Eder, (Mon Dec 22, 3:14 pm)

[PATCH 20/27] drivers/net/wan: fix sparse warnings: make do-..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 20/27] drivers/net/wan: fix sparse warnings: make..., Krzysztof Halasa, (Mon Dec 22, 6:09 pm)

[PATCH 09/27] drivers/net/e1000e: fix sparse warnings: make ..., Hannes Eder, (Mon Dec 22, 3:16 pm)

[PATCH 24/27] drivers/net/wireless/ath9k: fix sparse warning..., Hannes Eder, (Mon Dec 22, 3:18 pm)

[PATCH 27/27] drivers/net/wireless/prism54: fix sparse warni..., Hannes Eder, (Mon Dec 22, 3:19 pm)

Re: [PATCH 27/27] drivers/net/wireless/prism54: fix sparse w..., David Miller, (Fri Dec 26, 4:15 am)

[PATCH 25/27] drivers/net/wireless/b43: fix sparse warnings:..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 25/27] drivers/net/wireless/b43: fix sparse warni..., David Miller, (Fri Dec 26, 4:13 am)

[PATCH 26/27] drivers/net/wireless/ipw2x00: fix sparse warni..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 26/27] drivers/net/wireless/ipw2x00: fix sparse w..., David Miller, (Fri Dec 26, 4:14 am)

[PATCH 23/27] drivers/net/wireless: fix sparse warnings: mak..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 23/27] drivers/net/wireless: fix sparse warnings:..., David Miller, (Fri Dec 26, 4:13 am)

[PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warnings:..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warni..., David Miller, (Fri Dec 26, 4:12 am)

[PATCH 21/27] drivers/net/wan: fix sparse warning: make symb..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 21/27] drivers/net/wan: fix sparse warning: make ..., David Miller, (Fri Dec 26, 4:11 am)

[PATCH 19/27] drivers/net/usb: fix sparse warnings: make sym..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 19/27] drivers/net/usb: fix sparse warnings: make..., David Miller, (Fri Dec 26, 4:08 am)

[PATCH 18/27] drivers/net/tulip: fix sparse warnings: make d..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 18/27] drivers/net/tulip: fix sparse warnings: ma..., David Miller, (Fri Dec 26, 4:07 am)

[PATCH 17/27] drivers/net/tokenring: fix sparse warnings: ma..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 17/27] drivers/net/tokenring: fix sparse warnings..., David Miller, (Fri Dec 26, 4:07 am)

[PATCH 16/27] drivers/net/skfp: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 16/27] drivers/net/skfp: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:06 am)

[PATCH 15/27] drivers/net/qlge: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 15/27] drivers/net/qlge: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:05 am)

[PATCH 14/27] drivers/net/netxen: fix sparse warnings: use N..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 14/27] drivers/net/netxen: fix sparse warnings: u..., David Miller, (Fri Dec 26, 4:04 am)

[PATCH 13/27] drivers/net/ixgbe: fix sparse warnings: make s..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 13/27] drivers/net/ixgbe: fix sparse warnings: ma..., David Miller, (Fri Dec 26, 4:04 am)

[PATCH 12/27] drivers/net/irda: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 12/27] drivers/net/irda: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:03 am)

[PATCH 11/27] drivers/net/igb: remove dead code (function 'i..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 11/27] drivers/net/igb: remove dead code (functio..., Jeff Kirsher, (Mon Dec 22, 6:30 pm)

Re: [PATCH 11/27] drivers/net/igb: remove dead code (functio..., David Miller, (Fri Dec 26, 4:03 am)

[PATCH 10/27] drivers/net/enic: fix sparse warning: make sym..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 10/27] drivers/net/enic: fix sparse warning: make..., David Miller, (Fri Dec 26, 4:01 am)

[PATCH 08/27] drivers/net/cxgb3: comment out dead code, Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 08/27] drivers/net/cxgb3: comment out dead code, David Miller, (Fri Dec 26, 3:59 am)

[PATCH 06/27] drivers/net/atlx: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 06/27] drivers/net/atlx: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 3:58 am)

[PATCH 07/27] drivers/net/bonding: fix sparse warnings: move..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 07/27] drivers/net/bonding: fix sparse warnings: ..., David Miller, (Fri Dec 26, 3:59 am)

[PATCH 04/27] drivers/net: fix sparse warnings: make symbols..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 04/27] drivers/net: fix sparse warnings: make sym..., David Miller, (Fri Dec 26, 3:57 am)

[PATCH 05/27] drivers/net/arcnet: fix sparse warnings: make ..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 05/27] drivers/net/arcnet: fix sparse warnings: m..., David Miller, (Fri Dec 26, 3:57 am)

[PATCH 02/27] drivers/net: fix sparse warnings: make do-whil..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., David Miller, (Fri Dec 26, 3:55 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Mon Dec 22, 6:14 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Håkon Løvdal, (Mon Dec 22, 7:44 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 12:31 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Harvey Harrison, (Tue Dec 23, 1:26 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 1:36 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 2:08 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 7:18 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 7:38 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Hannes Eder, (Mon Dec 29, 10:35 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 10:03 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Junio C Hamano, (Thu Dec 25, 2:17 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 10:10 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Thu Dec 25, 1:02 pm)

[PATCH 03/27] drivers/net: fix sparse warning: returning voi..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., David Miller, (Fri Dec 26, 3:56 am)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., David Miller, (Thu Dec 25, 8:17 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Randy Dunlap, (Fri Dec 26, 3:59 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Hannes Eder, (Sat Dec 27, 3:11 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Sam Ravnborg, (Sat Dec 27, 3:20 pm)

[PATCH] Makefile: disable sparse warning "returning void-val..., Hannes Eder, (Sat Dec 27, 5:38 pm)

Re: [PATCH] Makefile: disable sparse warning "returning void..., Sam Ravnborg, (Sat Dec 27, 5:57 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Hannes Eder, (Fri Dec 26, 10:39 am)

[PATCH 01/27] drivers/net: fix sparse warning: use ANSI-styl..., Hannes Eder, (Mon Dec 22, 3:14 pm)

Re: [PATCH 01/27] drivers/net: fix sparse warning: use ANSI-..., David Miller, (Fri Dec 26, 3:53 am)

Navigation

Popular discussions


linux-kernel:

Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Roland Dreier	Re: Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
Radu Rendec	htb parallelism on multi-core platforms
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Colocation donated by:

Online users

Syndicate