Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement | KernelTrap

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Krzysztof Halasa <khc@...>

To: Håkon Løvdal <hlovdal@...>

Cc: Hannes Eder <hannes@...>, <netdev@...>, <kernel-janitors@...>, <linux-kernel@...>

Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement

Date: Tuesday, December 23, 2008 - 12:31 pm

"Håkon Løvdal" <hlovdal@gmail.com> writes:

quoted text> For this specific issue the important aspect is to improve readability
> (and not just eventually satisfy some warning from a tool), which I
> assume there is no disagrement on.

Precisely.

quoted text> Now what constitutes improved
> readbility on the other hand is another issue, and I guess there are
> next to as many oppinions as developers... :)

Yes. Thus the brackets (or lack of them) of do-while loops should
never be forced as a part of coding standard/tools. This is just an
unimportant detail of personal style and trying to force it is simply
damaging to all of us.

quoted text> Of secondary importance is the benefit that always using brackets
> makes them much more merge friendly.

There are many ways to make the code more merge friendly at a cost of
readability. Hope we don't go this way.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/27] drivers/net: fix sparse warnings, Hannes Eder, (Mon Dec 22, 3:14 pm)

[PATCH 20/27] drivers/net/wan: fix sparse warnings: make do-..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 20/27] drivers/net/wan: fix sparse warnings: make..., Krzysztof Halasa, (Mon Dec 22, 6:09 pm)

[PATCH 09/27] drivers/net/e1000e: fix sparse warnings: make ..., Hannes Eder, (Mon Dec 22, 3:16 pm)

[PATCH 24/27] drivers/net/wireless/ath9k: fix sparse warning..., Hannes Eder, (Mon Dec 22, 3:18 pm)

[PATCH 27/27] drivers/net/wireless/prism54: fix sparse warni..., Hannes Eder, (Mon Dec 22, 3:19 pm)

Re: [PATCH 27/27] drivers/net/wireless/prism54: fix sparse w..., David Miller, (Fri Dec 26, 4:15 am)

[PATCH 25/27] drivers/net/wireless/b43: fix sparse warnings:..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 25/27] drivers/net/wireless/b43: fix sparse warni..., David Miller, (Fri Dec 26, 4:13 am)

[PATCH 26/27] drivers/net/wireless/ipw2x00: fix sparse warni..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 26/27] drivers/net/wireless/ipw2x00: fix sparse w..., David Miller, (Fri Dec 26, 4:14 am)

[PATCH 23/27] drivers/net/wireless: fix sparse warnings: mak..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 23/27] drivers/net/wireless: fix sparse warnings:..., David Miller, (Fri Dec 26, 4:13 am)

[PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warnings:..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warni..., David Miller, (Fri Dec 26, 4:12 am)

[PATCH 21/27] drivers/net/wan: fix sparse warning: make symb..., Hannes Eder, (Mon Dec 22, 3:18 pm)

Re: [PATCH 21/27] drivers/net/wan: fix sparse warning: make ..., David Miller, (Fri Dec 26, 4:11 am)

[PATCH 19/27] drivers/net/usb: fix sparse warnings: make sym..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 19/27] drivers/net/usb: fix sparse warnings: make..., David Miller, (Fri Dec 26, 4:08 am)

[PATCH 18/27] drivers/net/tulip: fix sparse warnings: make d..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 18/27] drivers/net/tulip: fix sparse warnings: ma..., David Miller, (Fri Dec 26, 4:07 am)

[PATCH 17/27] drivers/net/tokenring: fix sparse warnings: ma..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 17/27] drivers/net/tokenring: fix sparse warnings..., David Miller, (Fri Dec 26, 4:07 am)

[PATCH 16/27] drivers/net/skfp: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 16/27] drivers/net/skfp: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:06 am)

[PATCH 15/27] drivers/net/qlge: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:17 pm)

Re: [PATCH 15/27] drivers/net/qlge: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:05 am)

[PATCH 14/27] drivers/net/netxen: fix sparse warnings: use N..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 14/27] drivers/net/netxen: fix sparse warnings: u..., David Miller, (Fri Dec 26, 4:04 am)

[PATCH 13/27] drivers/net/ixgbe: fix sparse warnings: make s..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 13/27] drivers/net/ixgbe: fix sparse warnings: ma..., David Miller, (Fri Dec 26, 4:04 am)

[PATCH 12/27] drivers/net/irda: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 12/27] drivers/net/irda: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 4:03 am)

[PATCH 11/27] drivers/net/igb: remove dead code (function 'i..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 11/27] drivers/net/igb: remove dead code (functio..., Jeff Kirsher, (Mon Dec 22, 6:30 pm)

Re: [PATCH 11/27] drivers/net/igb: remove dead code (functio..., David Miller, (Fri Dec 26, 4:03 am)

[PATCH 10/27] drivers/net/enic: fix sparse warning: make sym..., Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 10/27] drivers/net/enic: fix sparse warning: make..., David Miller, (Fri Dec 26, 4:01 am)

[PATCH 08/27] drivers/net/cxgb3: comment out dead code, Hannes Eder, (Mon Dec 22, 3:16 pm)

Re: [PATCH 08/27] drivers/net/cxgb3: comment out dead code, David Miller, (Fri Dec 26, 3:59 am)

[PATCH 06/27] drivers/net/atlx: fix sparse warnings: make sy..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 06/27] drivers/net/atlx: fix sparse warnings: mak..., David Miller, (Fri Dec 26, 3:58 am)

[PATCH 07/27] drivers/net/bonding: fix sparse warnings: move..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 07/27] drivers/net/bonding: fix sparse warnings: ..., David Miller, (Fri Dec 26, 3:59 am)

[PATCH 04/27] drivers/net: fix sparse warnings: make symbols..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 04/27] drivers/net: fix sparse warnings: make sym..., David Miller, (Fri Dec 26, 3:57 am)

[PATCH 05/27] drivers/net/arcnet: fix sparse warnings: make ..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 05/27] drivers/net/arcnet: fix sparse warnings: m..., David Miller, (Fri Dec 26, 3:57 am)

[PATCH 02/27] drivers/net: fix sparse warnings: make do-whil..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., David Miller, (Fri Dec 26, 3:55 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Mon Dec 22, 6:14 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Håkon Løvdal, (Mon Dec 22, 7:44 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 12:31 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Harvey Harrison, (Tue Dec 23, 1:26 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 1:36 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 2:08 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 7:18 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 7:38 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Hannes Eder, (Mon Dec 29, 10:35 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Tue Dec 23, 10:03 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Junio C Hamano, (Thu Dec 25, 2:17 am)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Linus Torvalds, (Tue Dec 23, 10:10 pm)

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-..., Krzysztof Halasa, (Thu Dec 25, 1:02 pm)

[PATCH 03/27] drivers/net: fix sparse warning: returning voi..., Hannes Eder, (Mon Dec 22, 3:15 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., David Miller, (Fri Dec 26, 3:56 am)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., David Miller, (Thu Dec 25, 8:17 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Randy Dunlap, (Fri Dec 26, 3:59 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Hannes Eder, (Sat Dec 27, 3:11 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Sam Ravnborg, (Sat Dec 27, 3:20 pm)

[PATCH] Makefile: disable sparse warning "returning void-val..., Hannes Eder, (Sat Dec 27, 5:38 pm)

Re: [PATCH] Makefile: disable sparse warning "returning void..., Sam Ravnborg, (Sat Dec 27, 5:57 pm)

Re: [PATCH 03/27] drivers/net: fix sparse warning: returning..., Hannes Eder, (Fri Dec 26, 10:39 am)

[PATCH 01/27] drivers/net: fix sparse warning: use ANSI-styl..., Hannes Eder, (Mon Dec 22, 3:14 pm)

Re: [PATCH 01/27] drivers/net: fix sparse warning: use ANSI-..., David Miller, (Fri Dec 26, 3:53 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
David Newall	Re: Slow DOWN, please!!!
Peter Zijlstra	[PATCH 00/23] per device dirty throttling -v8
linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc:

git:

Colocation donated by:

Who's online

There are currently 1 user and 624 guests online.

Online users

roundthejollyro

Syndicate