| > +static int ccid_request_module(u8 id)

| > +{

| > +       if (!in_atomic()) {

| > +               ccids_read_lock();

| > +               if (ccids[id] == NULL) {

| > +                       ccids_read_unlock();

| > +                       return request_module("net-dccp-ccid-%d", id);

| > +               }

| > +               ccids_read_unlock();

| > +       }

| > +       return 0;

| > +}

|

| Just a random thought: does this lock really do anything useful here?

|

Reading the (shared) 'ccids' array is the solution chosen to check whether

the module for CCID with number 'id' is already loaded.
It would be bad to call request_module() each time a new DCCP socket is

opened. Using the 'ccids' array may not be the only way to check whether

a given module (whose name depends on the value of 'id') is loaded. 
But if this solution is chosen, then it requires to protect the read

access to 'ccids', which is shared among all DCCP sockets.

--

To unsubscribe from this list: send the line "unsubscribe netdev" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html