Re: Regression: Bisected, IRQ and MSI allocations screwed without sparse irq

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Gleixner
Date: Thursday, November 20, 2008 - 5:34 pm

Jesper,

On Thu, 20 Nov 2008, Jesper Dangaard Brouer wrote:

Yup, the bisect result is pretty useless.
 

Can you please try the attached patch ?

Thanks,

	tglx

-----
 arch/x86/kernel/io_apic.c |   22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

Index: linux-2.6/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/io_apic.c
+++ linux-2.6/arch/x86/kernel/io_apic.c
@@ -3594,27 +3594,7 @@ int __init io_apic_get_redir_entries (in
 
 int __init probe_nr_irqs(void)
 {
-	int idx;
-	int nr = 0;
-#ifndef CONFIG_XEN
-	int nr_min = 32;
-#else
-	int nr_min = NR_IRQS;
-#endif
-
-	for (idx = 0; idx < nr_ioapics; idx++)
-		nr += io_apic_get_redir_entries(idx) + 1;
-
-	/* double it for hotplug and msi and nmi */
-	nr <<= 1;
-
-	/* something wrong ? */
-	if (nr < nr_min)
-		nr = nr_min;
-	if (WARN_ON(nr > NR_IRQS))
-		nr = NR_IRQS;
-
-	return nr;
+	return NR_IRQS;
 }
 
 /* --------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Tue Nov 4, 7:45 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 5, 12:05 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 5, 2:30 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 2:36 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 3:04 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 4:01 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 5:49 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 6:21 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Wed Nov 12, 2:31 pm)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Thu Nov 13, 1:50 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Thu Nov 13, 2:10 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapter, Jesper Dangaard Brouer, (Thu Nov 13, 3:29 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapt ..., Jesper Dangaard Brouer, (Fri Nov 14, 5:38 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapt ..., Jesper Dangaard Brouer, (Fri Nov 14, 11:49 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapt ..., Jesper Dangaard Brouer, (Wed Nov 19, 5:10 am)
Re: NIU driver: Sun x8 Express Quad Gigabit Ethernet Adapt ..., Jesper Dangaard Brouer, (Wed Nov 19, 3:58 pm)
Regression: Bisected, IRQ and MSI allocations screwed with ..., Jesper Dangaard Brouer, (Thu Nov 20, 12:48 pm)
Re: Regression: Bisected, IRQ and MSI allocations screwed ..., Thomas Gleixner, (Thu Nov 20, 5:34 pm)
Re: Regression: Bisected, IRQ and MSI allocations screwed ..., Jesper Dangaard Brouer, (Fri Nov 21, 3:33 am)
Re: Regression: Bisected, IRQ and MSI allocations screwed ..., Jesper Dangaard Brouer, (Fri Nov 21, 12:35 pm)