Home » Mailing list archives » linux-netdev » 2008 » November » 12

Re: [RFC PATCH 00/13] hardware time stamping + igb example implementation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: Re: [RFC PATCH 00/13] hardware time stamping + igb example implementation
Date: Wednesday, November 12, 2008 - 9:06 am

As a general comment on the patch series I'm still a little sceptical
the time stamp offset method is a good idea. Since it tries to approximate
several unsynchronized clocks the result will always be of a little poor
quality, which will likely lead to problems sooner or later (or rather
require ugly workarounds in the user).

I think it would be better to just bite the bullet and add new fields
for this to the skbs. Hardware timestamps are useful enough to justify
this.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC PATCH 03/13] user space API for time stamping of inco ..., Patrick Ohly, (Wed Oct 22, 8:01 am)
[RFC PATCH 04/13] net: implement generic SOF_TIMESTAMPING_ ..., Patrick Ohly, (Fri Oct 24, 6:41 am)
[RFC PATCH 05/13] ip: support for TX timestamps on UDP and ..., Patrick Ohly, (Fri Oct 24, 6:49 am)
[RFC PATCH 06/13] workaround: detect time stamp when comma ..., Patrick Ohly, (Wed Oct 29, 7:48 am)
[RFC PATCH 07/13] net: add SIOCSHWTSTAMP - hardware time s ..., Patrick Ohly, (Fri Oct 31, 4:43 am)
[RFC PATCH 08/13] igb: stub support for SIOCSHWTSTAMP, Patrick Ohly, (Fri Oct 31, 5:21 am)
[RFC PATCH 09/13] clocksource: allow usage independent of ..., Patrick Ohly, (Tue Nov 4, 2:23 am)
[RFC PATCH 10/13] igb: infrastructure for hardware time st ..., Patrick Ohly, (Tue Nov 4, 2:27 am)
[RFC PATCH 11/13] time sync: generic infrastructure to map ..., Patrick Ohly, (Wed Nov 5, 2:58 am)
[RFC PATCH 12/13] igb: use clocksync to implement hardware ..., Patrick Ohly, (Thu Nov 6, 4:13 am)
[RFC PATCH 13/13] skbuff: optionally store hardware time s ..., Patrick Ohly, (Fri Nov 7, 2:26 am)
[RFC PATCH 00/13] hardware time stamping + igb example imp ..., Patrick Ohly, (Tue Nov 11, 7:44 am)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., Andi Kleen, (Tue Nov 11, 9:18 am)
Re: [RFC PATCH 04/13] net: implement generic SOF_TIMESTAMP ..., Octavian Purdila, (Tue Nov 11, 4:15 pm)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., Patrick Ohly, (Wed Nov 12, 1:01 am)
Re: [RFC PATCH 04/13] net: implement generic SOF_TIMESTAMP ..., Patrick Ohly, (Wed Nov 12, 1:38 am)
Re: [RFC PATCH 05/13] ip: support for TX timestamps on UDP ..., David Miller, (Wed Nov 12, 2:59 am)
Re: [RFC PATCH 06/13] workaround: detect time stamp when c ..., David Miller, (Wed Nov 12, 3:00 am)
Re: [RFC PATCH 03/13] user space API for time stamping of ..., David Miller, (Wed Nov 12, 3:02 am)
Re: [RFC PATCH 09/13] clocksource: allow usage independent ..., David Miller, (Wed Nov 12, 3:04 am)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., David Miller, (Wed Nov 12, 3:05 am)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., David Miller, (Wed Nov 12, 3:08 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Andi Kleen, (Wed Nov 12, 9:06 am)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., Patrick Ohly, (Wed Nov 12, 9:14 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Patrick Ohly, (Wed Nov 12, 9:25 am)
Re: [RFC PATCH 11/13] time sync: generic infrastructure to ..., Eric Dumazet, (Wed Nov 12, 9:28 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Oliver Hartkopp, (Wed Nov 12, 11:44 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Eric Dumazet, (Wed Nov 12, 12:22 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Andi Kleen, (Wed Nov 12, 1:23 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Andi Kleen, (Wed Nov 12, 1:23 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Eric Dumazet, (Wed Nov 12, 1:56 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Andi Kleen, (Wed Nov 12, 2:34 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., David Miller, (Wed Nov 12, 3:17 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Oliver Hartkopp, (Wed Nov 12, 3:26 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Oliver Hartkopp, (Wed Nov 12, 11:15 pm)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Eric Dumazet, (Wed Nov 12, 11:29 pm)
RE: [RFC PATCH 00/13] hardware time stamping + igb example ..., Ohly, Patrick, (Thu Nov 13, 8:53 am)
RE: [RFC PATCH 00/13] hardware time stamping + igb example ..., Ohly, Patrick, (Thu Nov 13, 9:05 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Andrew Shewmaker, (Sun Nov 16, 1:15 am)
Re: [RFC PATCH 00/13] hardware time stamping + igb example ..., Patrick Ohly, (Wed Nov 19, 5:39 am)