Re: Fwd: [Bug 470774] New: [RFC1981-PMTU]Multicast Destination - One Router test failed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Brian Haley
Date: Tuesday, November 11, 2008 - 12:50 pm

Dave Jones wrote:

A little...


So which TAHI test was this?  Have they tracked down a commit that 
caused this to break?


Hmmm, I would take a look at this commit:

commit b5c15fc004ac83b7ad280acbe0fd4bbed7e2c8d4
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Thu Feb 14 23:49:37 2008 -0800

     [IPV6]: Fix reversed local_df test in ip6_fragment

     I managed to reverse the local_df test when forward-porting this
     patch so it actually makes things worse by never fragmenting at
     all.

     Thanks to David Stevens for testing and reporting this bug.

     Bill Fink pointed out that the local_df setting is also the wrong
     way around.

     Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
     Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 4e9a2fe..8b67ca0 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -621,7 +621,7 @@ static int ip6_fragment(struct sk_buff *skb, int 
(*output)(s
          * or if the skb it not generated by a local socket.  (This last
          * check should be redundant, but it's free.)
          */
-       if (skb->local_df) {
+       if (!skb->local_df) {
                 skb->dev = skb->dst->dev;
                 icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu, skb->dev);
                 IP6_INC_STATS(ip6_dst_idev(skb->dst), 
IPSTATS_MIB_FRAGFAILS);
@@ -1421,7 +1421,7 @@ int ip6_push_pending_frames(struct sock *sk)
         }

         /* Allow local fragmentation. */
-       if (np->pmtudisc >= IPV6_PMTUDISC_DO)
+       if (np->pmtudisc < IPV6_PMTUDISC_DO)
                 skb->local_df = 1;

         ipv6_addr_copy(final_dst, &fl->fl6_dst);



Where's the expected fragments?  See below where after the TOOBIG the 
next ping6 will generate them:


Maybe check the interface stats for IPv6 fragments and see why it failed:

# cat /proc/net/dev_snmp6/eth0 | grep -i frag

It would take me at least a day to get my TAHI box setup to test the 
latest net-next kernel to see if this is still broken upstream.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Fwd: [Bug 470774] New: [RFC1981-PMTU]Multicast Destina ..., Brian Haley, (Tue Nov 11, 12:50 pm)