From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Mon, 10 Nov 2008 00:23:09 +0100

quoted text
> Before commit b6c40d68ff6498b7f63ddf97cf0aa818d748dee7 ("net: only
> invoke dev->change_rx_flags when device is UP"), the dsa driver could
> sort-of get away with only fiddling with the master interface's
> allmulti/promisc counts in ->change_rx_flags() and not touching them
> in ->open() or ->stop().  After this commit (note that it was merged
> almost simultaneously with the dsa patches, which is why this wasn't
> caught initially), the breakage that was already there became more
> apparent.
> 
> Since it makes no sense to keep the master interface's allmulti or
> promisc count pinned for a slave interface that is down, copy the vlan
> driver's sync logic (which does exactly what we want) over to dsa to
> fix this.
> 
> Bug report from Dirk Teurlings <dirk@upexia.nl> and Peter van Valderen
> <linux@ddcrew.com>.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> Tested-by: Dirk Teurlings <dirk@upexia.nl>
> Tested-by: Peter van Valderen <linux@ddcrew.com>

Also applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html