[PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Guo-Fu Tseng
Date: Wednesday, October 8, 2008 - 2:57 pm

Dear Jeff, David:

This patch:

    Fix IRQ handle bug when interrupt mode.

    The driver was incorrectly handled and returned IRQ_HANDLED
    while the device is not generating the interrupt.
    It happened due to faulty determination of interrupt status register.

    The patch is also available at:
    http://cooldavid.org/download/jme.net-next-2.6.20081009.2.patch

    Found by: "Ethan" <ethanhsiao@jmicron.com>
    Fixed by: "akeemting" <akeem@jmicron.com>
    Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>

diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 635f616..3ab2442 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -1463,7 +1463,7 @@ jme_intr(int irq, void *dev_id)
 	/*
 	 * Check if it's really an interrupt for us
 	 */
-	if (unlikely(intrstat == 0))
+	if (unlikely((intrstat & INTR_ENABLE) == 0))
 		return IRQ_NONE;
 
 	/*

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver, Guo-Fu Tseng, (Mon Sep 15, 10:00 am)
[PATCH net-next-2.6 2/3] jme: Faulty IRQ handle bug fix, Guo-Fu Tseng, (Wed Oct 8, 2:57 pm)
[PATCH net-next-2.6 3/3] jme: Advances version number, Guo-Fu Tseng, (Wed Oct 8, 2:58 pm)
Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver, Stephen Hemminger, (Thu Nov 20, 10:20 pm)
Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver, Stephen Hemminger, (Thu Nov 20, 11:45 pm)
[PATCH net-2.6 2/2] jme: Remove 64 and 40 bit dma_mask, Guo-Fu Tseng, (Wed Dec 3, 3:44 am)
[PATCH net-next-2.6 2/4] jme: Fix pci sync, Guo-Fu Tseng, (Fri Feb 27, 8:57 pm)