Re: [PATCH] net: implement emergency route cache rebulds when gc_elasticity is exceeded

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Dickinson
Date: Sunday, October 5, 2008 - 11:06 am

I've got another patch that takes a different approach...  Instead of
disabling the secret_interval timer or trying to heuristically guess
when we're under attack, we continue to invalidate the cache; we just
invalidate it with kid-gloves instead of a sledge hammer.

Like we do today, we continue to update the genid every time the
secret_interval timer expires.  Instead of simply creating a new value
(and thus invalidating the entire cache), we keep a short history of
genid values (I'm thinking on the order of 2-4 previous values).  In
rt_intern_hash(), when we do the check to see if we already have an
existing hash entry, we'll check each of the previous genid versions
(hence the desire to keep the history short) before declaring it as
not there.  If we do find the entry in the hash with an older genid
value, we'll re-bucket it into the correct location for the latest
genid.

Basically, we're allowing entries to continue to exist in the hash
after the route cache has been invalidated (they can still be pruned
by GC).  Happy to send the patch along if you'd like, although I'm not
as confident that this approach is really desirable.

-A


On Sun, Oct 5, 2008 at 10:34 AM, David Miller <davem@davemloft.net> wrote:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] net: implement emergency route cache rebulds w ..., Andrew Dickinson, (Sun Oct 5, 11:06 am)
Re: [PATCH] net: implement emergency route cache rebulds w ..., Stephen Hemminger, (Thu Oct 16, 10:03 pm)
Re: [PATCH] net: implement emergency route cache rebulds w ..., Stephen Hemminger, (Thu Oct 16, 10:06 pm)