Home » Mailing list archives » linux-netdev » 2008 » October » 28

Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Evgeniy Polyakov
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables
Date: Monday, October 27, 2008 - 5:00 pm

Hi.

On Mon, Oct 27, 2008 at 07:58:33AM +0330, hamid jafarian (hamid.jafarian@gmail.com) wrote:

Frankly saying your codying style is way out of expected range of
allowed glitches, so it is quite hard to review the whole thing. Please
update it to at least remotely match existing code. Also I noticed you
do not use list iteration functions sometimes and replaces them with
direct access to next/prev pointers, which is not a good idea.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables, hamid jafarian, (Sun Oct 26, 9:28 pm)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Evgeniy Polyakov, (Mon Oct 27, 5:00 pm)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., David Miller, (Mon Oct 27, 5:02 pm)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., hamid jafarian, (Tue Oct 28, 3:02 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Evgeniy Polyakov, (Tue Oct 28, 3:43 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Patrick McHardy, (Tue Oct 28, 5:07 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Evgeniy Polyakov, (Tue Oct 28, 5:25 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Patrick McHardy, (Tue Oct 28, 5:30 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., Evgeniy Polyakov, (Tue Oct 28, 5:43 am)
Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IP ..., hamid jafarian, (Tue Oct 28, 5:57 am)