David Miller a =E9crit :
quoted text
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Mon, 13 Oct 2008 14:26:55 -0400
>=20
>> If this meets everyones approval I think we can follow up with a
>> patch to remove the secret interval code entirely.
>=20
> This patch looks pretty good to me.
>=20
> Just some minor coding style nits:
>=20
>> +static void rt_secret_rebuild_oneshot(struct net *net) {
>=20
> Openning brace on new line please.
>=20
>> +static void rt_emergency_hash_rebuild(struct net *net) {
>=20
> Likewise.
>=20
>=20

While browsing Neil patch, I found one missing rcu_assign_pointer()
in current code. I added a comment similar to other rcu_assign_pointer()
in rt_intern_hash() function.

[PATCH] ip: adds a missing rcu_assign_pointer()

rt_intern_hash() is doing an update of a RCU guarded hash chain
without using rcu_assign_pointer() or equivalent barrier.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>