Home » Mailing list archives » linux-netdev » 2008 » January » 29

Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

Previous thread: [VLAN]: set_rx_mode support for unicast address list by Patrick McHardy on Tuesday, January 29, 2008 - 8:09 am. (2 messages)

Next thread: [NET_SCHED]: sch_ingress: remove netfilter support by Patrick McHardy on Tuesday, January 29, 2008 - 8:28 am. (3 messages)
[view original message]
From: Rami Rosen
Subject: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
Date: Tuesday, January 29, 2008 - 8:14 am

Hi,
  In drivers/net/macvlan.c, when rtnl_link_register() fails
in macvlan_init_module(), there is no point to set it (second time in this
method) to macvlan_handle_frame; macvlan_init_module() will return a negative
number, so instead this patch sets macvlan_handle_frame_hook to NULL.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[ message continues ]
[view original message]
From: Patrick McHardy
Subject: Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
Date: Tuesday, January 29, 2008 - 8:19 am

Indeed, that seems to be a stupid cut-and-paste error. Thanks for
catching this.

Dave, please apply.
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
Date: Thursday, January 31, 2008 - 5:56 pm

From: Patrick McHardy <kaber@trash.net>

Done.
--


[ message continues ]
Previous thread: [VLAN]: set_rx_mode support for unicast address list by Patrick McHardy on Tuesday, January 29, 2008 - 8:09 am. (2 messages)

Next thread: [NET_SCHED]: sch_ingress: remove netfilter support by Patrick McHardy on Tuesday, January 29, 2008 - 8:28 am. (3 messages)