Fix a bunch of warnings in PPP and related drivers. Mostly because sparse doesn't like it when the the function is only marked private in the forward declaration. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- drivers/net/ppp_deflate.c | 4 ++-- drivers/net/ppp_generic.c | 2 +- drivers/net/ppp_synctty.c | 2 +- drivers/net/pppoe.c | 2 ++ drivers/net/slhc.c | 4 ++-- 5 files changed, 8 insertions(+), 6 deletions(-) --- a/drivers/net/ppp_de...

Since fib dump (via netlink) holds the RTNL mutex, it is unnecessary to use RCU, and it is impossible to get truncated (-EBUSY) result. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/ipv4/fib_trie.c 2008-01-23 13:55:12.000000000 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-23 14:00:35.000000000 -0800 @@ -1684,7 +1684,7 @@ static int trie_flush_leaf(struct trie * * Scan for the next right leaf starting at node p->child[idx] * Since we have back pointer, no recursion n...

Since fib_route_seq_show now uses hlist_for_each_entry(), the leaf info can not be NULL. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/ipv4/fib_trie.c 2008-01-22 17:50:44.000000000 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 17:50:58.000000000 -0800 @@ -2474,9 +2474,6 @@ static int fib_route_seq_show(struct seq struct fib_alias *fa; __be32 mask, prefix; - if (!li) - continue; - mask = inet_make_mask(li->plen); prefix = htonl(l->key); ...

Someone filed a bug at bugs.gentoo.org reflecting a possible enhancement to arping. In short the patches author felt that select should be used instead of signals to avoid missing a timeout. The bug is located at: http://bugs.gentoo.org/show_bug.cgi?id=144526 The diff follows: --- arping.c 2006-08-20 19:14:39.000000000 -0500 +++ /var/tmp/portage/iputils-021109-r3/work/iputils/arping.c 2006-08-20 19:17:40.000000000 -0500 @@ -7,9 +7,6 @@ * 2 of the License, or (at your option) any later ve...

Hi, This should be the last of my updates for 2.6.25: 1/3: pasemi_mac: Add support for changing mac address 2/3: pasemi_mac: add support for setting MTU 3/3: pasemi_mac: Disable interface on close Thanks, Olof --

Turns out we never disable the interface. It doesn't really cause any problems since the channel is off, but it's still better to do it this way. Signed-off-by: Olof Johansson <olof@lixom.net> diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index 059c6b0..2e39e02 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c @@ -1287,6 +1287,7 @@ static int pasemi_mac_close(struct net_device *dev) pasemi_mac_pause_txchan(mac); pasemi_mac_pause_rxint(mac); ...

Is  anyone aware if there an  NAT module for netfilter being developed for SCTP protocol ? I have searched the netfilter development tree source code and also mailing list and so far I have not found the NAT module for SCTP . There is SCTP conntrack module and packet match module. If anyone is aware and can point me to  some one who is already working on this or has evaluated this it would be of great help. SCTP is defined in [RFC 2960] Stewart, R., Xie, Q., Morneault, K., Sharp, C., Schwar...

[NET_SCHED]: Use nla_policy for attribute validation in classifiers Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit d177578bdf08849a388f1bc42a1d0566c6a3aded tree 2eda0cf1e0479dab464acda9def525df27bd4307 parent 76c3c24283fa9f78d8dc30c8eb73e0f11934bf69 author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:14:08 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:14:08 +0100 net/sched/cls_basic.c | 12 +++++++----- net/sched/cls_fw.c ...

[NET_SCHED]: Use nla_policy for attribute validation in ematches Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit 9420f06512465a8a90f3ff0df8b943989bc7e2e7 tree 7556b31b93647c9d2c30eb567b50671d368f8ced parent 99302e1c1ed003305e9a0102aa772e2f2d61114c author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:23:09 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:23:09 +0100 net/sched/em_meta.c | 9 ++++++--- net/sched/ematch.c | 11 ++++...

[NET_SCHED]: Use nla_policy for attribute validation in actions Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit 99302e1c1ed003305e9a0102aa772e2f2d61114c tree 05286e8f9d74ad273d6a6e12d7bc794a19c4ea4c parent d177578bdf08849a388f1bc42a1d0566c6a3aded author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:23:07 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:23:07 +0100 net/sched/act_gact.c | 15 ++++++++------- net/sched/act_ipt.c ...

[NET_SCHED]: Use NLA_PUT_STRING for string dumping Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit ad688fbdf7dd0ebeb1b2fba0d7d2105bdf3c6de9 tree 68bb3e1dc3484d6ca0e7ddc55ad4e25864aaac84 parent bdd38a3b14cfa340da580f6e825d7f1142925926 author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:55 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:55 +0100 net/sched/act_api.c | 4 ++-- net/sched/act_ipt.c | 2 +- net/sched/cls_api....

[Empty message]

[NET_SCHED]: act_api: use PTR_ERR in tcf_action_init/tcf_action_get Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit 0919ac24aa4bd6978806f35f8daefe32aa997823 tree 95e2c04521d6a09c080eac8735ab0598c3b3ff5b parent f9f9cbaccb1a58ea02318250192effe1e2e1e715 author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:41 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:41 +0100 include/net/act_api.h | 4 +-- net/sched/act_api.c | 71 +++...

[NET_SCHED]: act_api: fix netlink API conversion bug Fix two invalid attribute accesses, indices start at 1 with the new netlink API. Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit 512b2ab20730e1d24e36fb94eab4a2731e90e315 tree e3583125570ee0c7a57feac7aa6fcabe2541112a parent 1af28b79f4f0a67db344938ef6739ad2af1a72a7 author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:10:00 +0100 committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:10:00 +0100 ...

[NET_SCHED]: sch_atm: fix format string warning Fix format string warning introduces by the netlink API conversion: net/sched/sch_atm.c:250: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'int'. Signed-off-by: Patrick McHardy <kaber@trash.net> --- commit 3bab4166cf0350552419d7871b4df463c5aed2ea tree c08015e39f6f1da0255f1325cc21dfda0c738bc2 parent a7f92e3b13a5e3db64383c503f2249dc74b41bd6 author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 16:...

Steven Whitehouse <swhiteho@redhat.com> wrote: Thanks for the report; I know what the problem here is. I'll That would be helpful, as would some more details: e.g., the various options passed to bonding, the complete dmesg log, contents of /proc/net/bonding/bond0 [or whatever your interface is called], and anything else you think would be helpful. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com --

Hi, - Remove an unused definition (LAT_BUCKETS_MAX) in net/core/pktgen.c. - Remove the corresponding comment. - The LAT_BUCKETS_MAX seems to have to do with a patch from a long time ago which was not applied (Ben Greear), which dealt with latency counters. See, for example : http://oss.sgi.com/archives/netdev/2002-09/msg00184.html Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@gmail.com>

(Changes since last time: we how have explicit IFF_RECV_CSUM and IFF_RECV_GSO bits, and some renaming of virtio_net hdr) We use the virtio_net_hdr: it is an ABI already and designed to encapsulate such metadata as GSO and partial checksums. IFF_VIRTIO_HDR means you will write and read a 'struct virtio_net_hdr' at the start of each packet. You can always write packets with partial checksum and gso to the tap device using this header. IFF_RECV_CSUM means you can handle reading packets with part...

A userspace program may wish to set the mark for each packets its send without using the netfilter MARK target. Changing the mark can be used mark based routing without netfilter or for packet filtering. It requires CAP_NET_ADMIN capability. Signed-off-by: Laszlo Attila Toth <panther@balabit.hu> --- include/asm-alpha/socket.h | 2 ++ include/asm-arm/socket.h | 2 ++ include/asm-avr32/socket.h | 2 ++ include/asm-blackfin/socket.h | 3 +++ include/asm-cris/socket.h...

Francois noted that these warranted promotion from net-2.6.25.git to current 2.6.24-rc. NOTE: These changesets were cherry-picked from net-2.6.25, without any modifications. Any future rebase or merge should hopefully notice this automatically. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/net/sis190.c | 21 ++++++++++----------- 1 files changed, 10 insertions...

Since you can easily reproduce it, lets just figure out what's causing it Well, that's annoying, you didn't mention net-2.6.25 back then, it sure ...This is either due to mismerge or due your modifications. Lets re-iterate, compiled ok for me tcp_{ipv4,input,output}.o... -- i. [PATCH] [TCP]: debug S+L (for net-2.5.26 / mm, incompatible with mainline) --- include/net/tcp.h | 8 +++- net/ipv4/tcp_input.c | 10 +++++ net/ipv4/tcp_ipv4.c | 107 ++++++++++++++++++++++++...

I don't have a clue why it didn't go to the checking func (or it didn't print anything) but just had those WARN_ONs... Hopefully this is giving somewhat better input (applies on top of the other debug patch). -- i. [PATCH] [TCP]: more debug --- include/net/tcp.h | 3 ++- net/ipv4/tcp_input.c | 9 ++++++++- net/ipv4/tcp_ipv4.c | 19 ++++++++++++++----- 3 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 0685035..129c...

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi> Right, this would be something to consider for the net-2.6.25 and thus -mm cases, but not for 2.6.24* since this patch didn't go there. I don't see how this change could matter offhand. Even with that incorrect TSO test, the same set of write queue configurations can still occur just some less likely than after the patch. I also suspect this one isn't the cause. I think we'll be better off once we get some more data, and therefore ...

when killing a wvdial usb modem session: Jan 22 23:23:03 dual pppd[7941]: Terminating on signal 15 Jan 22 23:23:03 dual pppd[7941]: Connect time 92.2 minutes. Jan 22 23:23:03 dual pppd[7941]: Sent 1322316 bytes, received 8587156 bytes. Jan 22 23:23:03 dual pppd[7941]: Connection terminated. Jan 22 23:23:05 dual kernel: usb 3-2: USB disconnect, address 5 Jan 22 23:23:05 dual kernel: option 3-2:1.0: device disconnected Jan 22 23:23:05 dual kernel: option1 ttyUSB1: GSM modem (1-port) converter now d...

From: maximilian attems <max@stro.at> Already fixed by: [NEIGH]: Revert 'Fix race between neigh_parms_release and neightbl_fill_parms' Commit 9cd40029423701c376391da59d2c6469672b4bed (Fix race between neigh_parms_release and neightbl_fill_parms) introduced device reference counting regressions for several people, see: http://bugzilla.kernel.org/show_bug.cgi?id=9778 for example. Signed-off-by: David S. Miller <davem@davemloft.net> diff --git a/net/core/neighbour.c b/net/co...