Home » Mailing list archives » linux-netdev » 2008 » January » 23

[IPV4 2/5] fib_trie: remove unneeded NULL check

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stephen Hemminger <shemminger@...>
To: David Miller <davem@...>
Cc: <netdev@...>
Subject: [IPV4 2/5] fib_trie: remove unneeded NULL check
Date: Wednesday, January 23, 2008 - 6:48 pm

Since fib_route_seq_show now uses hlist_for_each_entry(), the
leaf info can not be NULL.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/net/ipv4/fib_trie.c	2008-01-22 17:50:44.000000000 -0800
+++ b/net/ipv4/fib_trie.c	2008-01-22 17:50:58.000000000 -0800
@@ -2474,9 +2474,6 @@ static int fib_route_seq_show(struct seq
 		struct fib_alias *fa;
 		__be32 mask, prefix;
 
-		if (!li)
-			continue;
-
 		mask = inet_make_mask(li->plen);
 		prefix = htonl(l->key);
 

-- 
Stephen Hemminger <stephen.hemminger@vyatta.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[IPV4 2/5] fib_trie: remove unneeded NULL check, Stephen Hemminger, (Wed Jan 23, 6:48 pm)
Re: [IPV4 2/5] fib_trie: remove unneeded NULL check, David Miller, (Thu Jan 24, 12:38 am)