[NET_SCHED 11/15]: sch_api: introduce constant for rate table size

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <davem@...>
Cc: <netdev@...>, Patrick McHardy <kaber@...>
Date: Wednesday, January 23, 2008 - 12:36 pm

[NET_SCHED]: sch_api: introduce constant for rate table size

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit b21f31e516f993016f8a1ade331bcaf71576b4e2
tree e59049e1fb3f2711d83c196d2f54b5021dc68330
parent 3e73383f7c353af51e8cc475f1c217a6b81fcecf
author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:56 +0100
committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:12:56 +0100

 include/linux/pkt_sched.h |    2 ++
 net/sched/sch_api.c       |    3 ++-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/include/linux/pkt_sched.h b/include/linux/pkt_sched.h
index 919af93..3276135 100644
--- a/include/linux/pkt_sched.h
+++ b/include/linux/pkt_sched.h
@@ -83,6 +83,8 @@ struct tc_ratespec
 	__u32		rate;
 };
 
+#define TC_RTAB_SIZE	1024
+
 /* FIFO section */
 
 struct tc_fifo_qopt
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 8db554d..7e3c048 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -244,7 +244,8 @@ struct qdisc_rate_table *qdisc_get_rtab(struct tc_ratespec *r, struct nlattr *ta
 		}
 	}
 
-	if (tab == NULL || r->rate == 0 || r->cell_log == 0 || nla_len(tab) != 1024)
+	if (tab == NULL || r->rate == 0 || r->cell_log == 0 ||
+	    nla_len(tab) != TC_RTAB_SIZE)
 		return NULL;
 
 	rtab = kmalloc(sizeof(*rtab), GFP_KERNEL);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[NET_SCHED 00/15]: Make use of new netlink API features, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 11/15]: sch_api: introduce constant for rate tabl..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 09/15]: Use typeful attribute construction helpers, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 08/15]: Use NLA_PUT_STRING for string dumping, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 10/15]: Use typeful attribute parsing helpers, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 07/15]: Use nla_nest_start/nla_nest_end, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 06/15]: Propagate nla_parse return value, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 04/15]: act_api: use nlmsg_parse, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 03/15]: act_api: fix netlink API conversion bug, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 02/15]: sch_netem: use nla_parse_nested_compat, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 01/15]: sch_atm: fix format string warning, Patrick McHardy, (Wed Jan 23, 12:36 pm)