Home » Mailing list archives » linux-netdev » 2008 » January » 23

[NET_SCHED 03/15]: act_api: fix netlink API conversion bug

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Patrick McHardy <kaber@...>
To: <davem@...>
Cc: <netdev@...>, Patrick McHardy <kaber@...>
Subject: [NET_SCHED 03/15]: act_api: fix netlink API conversion bug
Date: Wednesday, January 23, 2008 - 12:36 pm

[NET_SCHED]: act_api: fix netlink API conversion bug

Fix two invalid attribute accesses, indices start at 1 with the new
netlink API.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 512b2ab20730e1d24e36fb94eab4a2731e90e315
tree e3583125570ee0c7a57feac7aa6fcabe2541112a
parent 1af28b79f4f0a67db344938ef6739ad2af1a72a7
author Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:10:00 +0100
committer Patrick McHardy <kaber@trash.net> Wed, 23 Jan 2008 17:10:00 +0100

 net/sched/act_api.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index ebd21d2..ae077ed 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -997,11 +997,11 @@ find_dump_kind(struct nlmsghdr *n)
 	if (nla_parse(tb, TCA_ACT_MAX_PRIO, nla_data(tb1),
 		      NLMSG_ALIGN(nla_len(tb1)), NULL) < 0)
 		return NULL;
-	if (tb[0] == NULL)
-		return NULL;
 
-	if (nla_parse(tb2, TCA_ACT_MAX, nla_data(tb[0]),
-		      nla_len(tb[0]), NULL) < 0)
+	if (tb[1] == NULL)
+		return NULL;
+	if (nla_parse(tb2, TCA_ACT_MAX, nla_data(tb[1]),
+		      nla_len(tb[1]), NULL) < 0)
 		return NULL;
 	kind = tb2[TCA_ACT_KIND];
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[NET_SCHED 00/15]: Make use of new netlink API features, Patrick McHardy, (Wed Jan 23, 12:36 pm)
Re: [NET_SCHED 00/15]: Make use of new netlink API features, David Miller, (Thu Jan 24, 12:37 am)
[NET_SCHED 13/15]: Use nla_policy for attribute validation i..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 12/15]: Use nla_policy for attribute validation i..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 15/15]: Use nla_policy for attribute validation i..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 11/15]: sch_api: introduce constant for rate tabl..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 14/15]: Use nla_policy for attribute validation i..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 09/15]: Use typeful attribute construction helpers, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 08/15]: Use NLA_PUT_STRING for string dumping, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 10/15]: Use typeful attribute parsing helpers, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 07/15]: Use nla_nest_start/nla_nest_end, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 06/15]: Propagate nla_parse return value, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 05/15]: act_api: use PTR_ERR in tcf_action_init/t..., Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 04/15]: act_api: use nlmsg_parse, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 03/15]: act_api: fix netlink API conversion bug, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 02/15]: sch_netem: use nla_parse_nested_compat, Patrick McHardy, (Wed Jan 23, 12:36 pm)
[NET_SCHED 01/15]: sch_atm: fix format string warning, Patrick McHardy, (Wed Jan 23, 12:36 pm)