SFQ: backport some features from ESFQ (try 4)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Corey Hickey
Date: Friday, September 28, 2007 - 3:52 pm

Patchset try 2 addresses the review by Michael Buesch.
Patchset try 3 addresses the review by Patrick McHardy.
Patchset try 4 has a few cosmetic improvements.

Nobody reviewed my last set of patches, and I wasn't pushy about asking.
Since it's been a while, I ported the kernel and userspace patchsets to
current git of net-2.6 and iproute2, respectively.

The first 7 patches in this series resemble the corresponding 7 patches
in patchset try 2. There aren't any major changes--just modifications
to address errors noticed in review and slight reorganizations to make
the next patches easier.

Patches 8-10 implement parameter passing via nested compat attributes.
This is necessary for using 'tc qdisc change' to disable perturbation.
The rest of the parameters were added for consistency.

Iproute2 patches will follow shortly.



The following is the original patch text.

This set of patches adds some of ESFQ's modifications to the original 
SFQ. Thus far, I have received support for this approach rather than for 
trying to get ESFQ included as a separate qdisc.

http://mailman.ds9a.nl/pipermail/lartc/2007q2/021056.html

My patches here implement "tc qdisc change", user-configurable depth 
(number of flows), and user-configurable divisor (for setting hash table 
size). I've left out the remaining ESFQ features (usage of jhash and 
different hashing methods) because Patrick McHardy intends to submit a 
patch that will supersede that functionality; see the URL above.

Default values remain the same, and SFQ's default behavior remains the 
same, so there should be no user disruption.

Thanks for your consideration,
Corey



 include/linux/pkt_sched.h |   23 ++--
 net/sched/sch_sfq.c       |  353 ++++++++++++++++++++++++++++++---------------
 2 files changed, 254 insertions(+), 122 deletions(-)


[PATCH 01/10] Preparatory refactoring part 1.
[PATCH 02/10] Preparatory refactoring part 2.
[PATCH 03/10] Move two functions.
[PATCH 04/10] Make "depth" (number of queues) user-configurable:
[PATCH 05/10] Add divisor.
[PATCH 06/10] Make qdisc changeable.
[PATCH 07/10] Remove comments about hardcoded values.
[PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned.
[PATCH 09/10] Change perturb_period to unsigned.
[PATCH 10/10] Use nested compat attributes to pass parameters.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
SFQ: backport some features from ESFQ (try 4), Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 01/10] Preparatory refactoring part 1., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 02/10] Preparatory refactoring part 2., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 03/10] Move two functions., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 05/10] Add divisor., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 06/10] Make qdisc changeable., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 07/10] Remove comments about hardcoded values., Corey Hickey, (Fri Sep 28, 3:52 pm)
[PATCH 09/10] Change perturb_period to unsigned., Corey Hickey, (Fri Sep 28, 3:52 pm)
sfq, Corey Hickey, (Fri Sep 28, 3:54 pm)
[PATCH 1/3] SFQ: Support changing depth and divisor., Corey Hickey, (Fri Sep 28, 3:54 pm)
[PATCH 2/3] Change perturb_period to unsigned., Corey Hickey, (Fri Sep 28, 3:54 pm)
Re: sfq (iproute2 patches), Corey Hickey, (Fri Sep 28, 3:57 pm)
Re: SFQ: backport some features from ESFQ (try 4), Patrick McHardy, (Sat Sep 29, 8:38 am)
Re: SFQ: backport some features from ESFQ (try 4), Corey Hickey, (Sat Sep 29, 10:36 am)
Re: [PATCH 01/10] Preparatory refactoring part 1., Patrick McHardy, (Mon Oct 1, 6:25 am)
Re: [PATCH 03/10] Move two functions., Patrick McHardy, (Mon Oct 1, 6:27 am)
Re: [PATCH 02/10] Preparatory refactoring part 2., Patrick McHardy, (Mon Oct 1, 6:33 am)
Re: [PATCH 05/10] Add divisor., Patrick McHardy, (Mon Oct 1, 6:38 am)
Re: [PATCH 06/10] Make qdisc changeable., Patrick McHardy, (Mon Oct 1, 6:43 am)
Re: [PATCH 09/10] Change perturb_period to unsigned., Patrick McHardy, (Mon Oct 1, 6:45 am)
Re: [PATCH 01/10] Preparatory refactoring part 1., Corey Hickey, (Mon Oct 1, 1:46 pm)
Re: [PATCH 02/10] Preparatory refactoring part 2., Corey Hickey, (Mon Oct 1, 1:46 pm)
Re: [PATCH 03/10] Move two functions., Corey Hickey, (Mon Oct 1, 1:46 pm)
Re: [PATCH 05/10] Add divisor., Corey Hickey, (Mon Oct 1, 1:47 pm)
Re: [PATCH 06/10] Make qdisc changeable., Corey Hickey, (Mon Oct 1, 1:47 pm)
Re: [PATCH 09/10] Change perturb_period to unsigned., Corey Hickey, (Mon Oct 1, 1:47 pm)
Re: [PATCH 01/10] Preparatory refactoring part 1., Patrick McHardy, (Mon Oct 1, 8:17 pm)
Re: [PATCH 02/10] Preparatory refactoring part 2., Patrick McHardy, (Mon Oct 1, 8:19 pm)