Home » Mailing list archives » linux-netdev » 2007 » September » 19

[PATCH 2/6] sky2: ethtool speed report bug

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stephen Hemminger <shemminger@...>
To: Jeff Garzk <jgarzik@...>
Cc: <netdev@...>
Subject: [PATCH 2/6] sky2: ethtool speed report bug
Date: Wednesday, September 19, 2007 - 6:36 pm

On 100mbit versions, the driver always reports gigabit speed
available. The correct modes are already computed, then overwritten.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>


--- a/drivers/net/sky2.c	2007-09-19 09:18:50.000000000 -0700
+++ b/drivers/net/sky2.c	2007-09-19 09:19:35.000000000 -0700
@@ -2841,13 +2841,6 @@ static int sky2_get_settings(struct net_
 	ecmd->supported = sky2_supported_modes(hw);
 	ecmd->phy_address = PHY_ADDR_MARV;
 	if (sky2_is_copper(hw)) {
-		ecmd->supported = SUPPORTED_10baseT_Half
-		    | SUPPORTED_10baseT_Full
-		    | SUPPORTED_100baseT_Half
-		    | SUPPORTED_100baseT_Full
-		    | SUPPORTED_1000baseT_Half
-		    | SUPPORTED_1000baseT_Full
-		    | SUPPORTED_Autoneg | SUPPORTED_TP;
 		ecmd->port = PORT_TP;
 		ecmd->speed = sky2->speed;
 	} else {

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2/6] sky2: ethtool speed report bug, Stephen Hemminger, (Wed Sep 19, 6:36 pm)