The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com> --- net/ipv4/fib_hash.c | 3 +++ net/ipv4/fib_lookup.h | 3 ++- net/ipv4/fib_semantics.c | 20 +++++++++++++++++--- net/ipv4/fib_trie.c | 1 + 4 files changed...

A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com> --- include/linux/rtnetlink.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h index c91476c..68046a4 100644 --- a/include/linux/rtnetlink.h +++ b/include/linux/rtnetlink.h @@ -263,6 +263,7 @@ enum rtattr_type_t RTA_SESSION, RTA_MP_ALGO, /* no longer use...

This is a preliminary posting of my Sun Neptune driver against the net-2.6.24 tree. The TODO list is very long, but it's a lot of small things, most of the basic substance of the driver is all there. Things which are known to be broken: 1) Niagara-2 frontend not written, I have recently received the hardware necessary to code that part up. 2) Jumbo MTU. I have to add some code to adjust the RBR sizes when the MTU goes above 1500, should be about an afternoon of work. 3) Need ...

From: "John W. Linville" <linville@tuxdriver.com> Applied to net-2.6.24 and pushed out. Thanks John. -

[L2TP] Fix double skb free problem introduced by recent changes This patch is to be applied on top of Herbert's recent patch set: "[PPP 3/3] L2TP: Fix skb handling in pppol2tp_xmit" It fixes a double kfree_skb() issue introduced by that patch. Also return 0 on error, allowing PPP to requeue the skb. Signed-off-by: James Chapman <jchapman@katalix.com> Index: net-2.6.24/drivers/net/pppol2tp.c =================================================================== --- net-2.6.24.orig/drivers...

Yep it looks good. I should've read my emails from the bottom up :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -

See my attached patch, thanks. /holger

The previous patchlet wasn't correct, please apply this one. Sorry for the noise. /holger

From: "John W. Linville" <linville@tuxdriver.com> John, I'm adding this and the iwlwifi bits to my net-2.6.24 tree. Thanks. -

Sorry, I added a double-free on the skb after ip_queue_xmit. Please try this one instead. [PPP] L2TP: Fix skb handling in pppol2tp_xmit This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify cloned skb data. It also gets rid of skb2 we only need to preserve the original skb for congestion notification, which is only applicable for ppp_async and ppp_sync. The other semantic change made here is the removal of socket accounting for data tranmitted out of pppol2tp_xmit. The o...

I think it was because of a double-free that I created after transmitting the packet. In fact I had the same bug in PPPOE too. [PPP] pppoe: Fix double-free on skb after transmit failure When I got rid of the second packet in __pppoe_xmit I created a double-free on the skb because of the goto abort on failure. This patch removes that. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <h...

Acked-by: James Chapman <jchapman@katalix.com> -

Return some useful information such as the maximum listen backlog and the current listen backlog in the tcp_info structure and INET_DIAG_INFO. Signed-off-by: Rick Jones <rick.jones2@hp.com> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> --- diff -r bdcdd0e1ee9d net/ipv4/tcp.c --- a/net/ipv4/tcp.c Sat Sep 01 07:00:31 2007 +0000 +++ b/net/ipv4/tcp.c Tue Sep 18 11:02:26 2007 -0700 @@ -2030,8 +2030,14 @@ void tcp_get_info(struct sock *sk, struc info->tcpi_snd_mss = tp->mss_ca...

Jeff & Dave, Here it is -- it's big, it's...well...beautiful in its own way...well, at least it seems to work... :-) There are some outstanding issues. The driver does more than it probably should under the covers instead of in the stack, and the issue of including headers with a "../../mac80211/..." path remains. Still, I think it would be better to get this mainlined than to keep it out of stream. Thanks! John --- Patch available here: [ message continues ]

In doing some stress testing of the NetXen driver, I found that my machine was dying in all sorts of weird ways. I saw several different crashes, BUG messages in the TCP stack and some assert messages in the TCP stack as well. I really didn't think that there could be six different bugs all at once in the TCP/IP stack, so I started looking at possible memory corruption. I first saw this on 2.6.16-rt22 with a backported netxen driver from 2.6.22. I figured I should try the latest kernel, so I...

You don't need to store and fetch zeros at all. You *know* that they are zeros, right? So do this: - REG_WR_IND(bp, offset, fw->bss[j]); + REG_WR_IND(bp, offset, 0); -- vda -

From: "Michael Chan" <mchan@broadcom.com> I don't like it because it means people have to setup full initrd's in order to do network booting with such network cards. But the days of my opinion mattering on that issue are long gone, the momentum is just too greatly behind using request_firmware() across the board, so there is no reason for bnx2 to be any different. -

From: "H. Peter Anvin" <hpa@zytor.com> I appreciate the effort you put into klibc and the offer to make initrd's easier to build. But the point is that the initrd shouldn't be necessary in the first place. There becomes zero point in building these drivers statically into the kernel, which many of us do specifically to avoid module loading, initrds, and all that fuss. Because the driver is totally crippled even though it's been fully built into the main kernel image. I mean, it's so in...

From: "H. Peter Anvin" <hpa@zytor.com> Sounds good to me :) -

At least as of the last merged tree it was very smooth indeed, thanks to your help. -hpa -

From: "Michael Chan" <mchan@broadcom.com> Like I said, I think neither should change and the driver should -

From: Willy Tarreau <w@1wt.eu> So let's save 60K instead of 80K. I mean, the entire discussion is just plain silly :) -

The bnx2 chip requires a lot of firmware to begin with, so it won't save much space no matter what version is used in the kernel. We update the firmware to fix bugs and sometimes to add new features. New features often require matching changes in the driver. For example, we're planning to add S/G support for jumbo rx frames and this requires changes in both driver and firmware. It's possible to make the driver work with multiple firmware versions, but that adds complexity to enable/disable cer...

Is it a NULL pointer or something random? -

OK the off-by-one prevents an out-of-bounds array access, which would cause a crash itself. Despite what I said above, sfq does try to handle dequeues while empty, but forgets to update q->tail when dropping the last packet from the only active queue, probably because it wasn't expected that the queue length is too small to queue even a single packet (and that really doesn't make much sense). So one possibility for fixing this is to update q->tail in sfq_drop when dropping the last packet...