On Tue, Sep 18, 2007 at 01:32:40PM -0700, David Miller wrote:I think it was because of a double-free that I created after transmitting the packet. In fact I had the same bug in PPPOE too. [PPP] pppoe: Fix double-free on skb after transmit failure When I got rid of the second packet in __pppoe_xmit I created a double-free on the skb because of the goto abort on failure. This patch removes that. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index 0d7f570..9b30cd6 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -879,8 +879,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb) dev->hard_header(skb, dev, ETH_P_PPP_SES, po->pppoe_pa.remote, NULL, data_len); - if (dev_queue_xmit(skb) < 0) - goto abort; + dev_queue_xmit(skb); return 1; - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| Christoph Hellwig | Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interface for on access scan... |
| David Miller | [GIT]: Networking |
| Bart Van Assche | Integration of SCST in the mainstream Linux kernel |
| Tetsuo Handa | Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation,pathname matching |
git: | |
| Junio C Hamano | [RFD] On deprecating "git-foo" for builtins |
| Raimund Bauer | [wishlist] graphical diff |
| Dana How | [PATCH v3] Support ent:relative_path |
| Li Frank-B20596 | why not TortoiseGit |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Natalie Protasevich | [BUG] New Kernel Bugs |
| Glenn Griffin | [PATCH] Add IPv6 support to TCP SYN cookies |
| Alexey Suslikov | OT: OpenBSD on Asus eeePC |
| Daniele Pilenga | HP nw9440 does not boot ACPI snapshot |
| Peter | OpenBSD as Virtualbox guest |
| Calomel | Re: Remove escape characters from file |
