[L2TP] Fix double skb free problem introduced by recent changes This patch is to be applied on top of Herbert's recent patch set: "[PPP 3/3] L2TP: Fix skb handling in pppol2tp_xmit" It fixes a double kfree_skb() issue introduced by that patch. Also return 0 on error, allowing PPP to requeue the skb. Signed-off-by: James Chapman <jchapman@katalix.com> Index: net-2.6.24/drivers/net/pppol2tp.c =================================================================== --- net-2.6.24.orig/drivers/net/pppol2tp.c +++ net-2.6.24/drivers/net/pppol2tp.c @@ -1066,11 +1066,10 @@ static int pppol2tp_xmit(struct ppp_chan session->stats.tx_errors++; } - /* Free the original skb */ -abort: - kfree_skb(skb); - return 1; + +abort: + return 0; } /***************************************************************************** - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| holzheu | [RFC/PATCH] Documentation of kernel messages |
| jjohansen | [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching |
| Vladislav Bolkhovitin | Re: Integration of SCST in the mainstream Linux kernel |
| Joerg Roedel | [PATCH 04/34] AMD IOMMU: add data structures to manage the IOMMUs in the system |
git: | |
| David Kastrup | Empty directories... |
| Tim Ansell | Whats happening with git-notes? |
| Johannes Schindelin | [PATCH 2/2] diff: add custom regular expressions for function names |
| Han-Wen Nienhuys | git branch performance problem? |
| Mayuresh Kathe | Richard Stallman... |
| Richard Daemon | OpenBSD 4.3 running in VirtualBox? Anyone have it working properly? |
| William Boshuck | Re: Longest Uptime? |
| Sean Hafeez | hostname.pppoe0 with AT&T/SBC debug? |
| Patrick Ohly | [RFC PATCH 00/13] hardware time stamping + igb example implementation |
| Johannes Berg | mac80211 truesize bugs |
| Denys | r8169 crash |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
