Home » Mailing list archives » linux-netdev » 2007 » November » 15

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alexey Kuznetsov <kuznet@...>
To: Jonas Danielsson <the.sator@...>
Cc: <linux-kernel@...>, <davem@...>, <jmorris@...>, <netdev@...>, <akpm@...>
Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)
Date: Thursday, November 15, 2007 - 11:40 am

Hello!


I do not see anything more legal in setting target address to 0.


Actually, semantics of target address in ARP reply is ambiguous.
If it is a reply to some real request, it is set to address of requestor
and protocol requires recipient of this arp reply to test that the address
matches its own address before creating new entry triggered by unsolicited
arp reply. That's all.

In the case of duplicate address detection, requestor does not have
any address, so that it is absolutely not essential what we use as target
address. The only place, which could depend on this is the tool, which
tests for duplicate address. At least, arping written by me, should
work with any variant.

So, please, could you explain what did force you to think that use of 0
is better?

Alexey
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was:..., Jonas Danielsson, (Thu Nov 15, 7:40 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (..., Alexey Kuznetsov, (Thu Nov 15, 11:40 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (..., Jonas Danielsson, (Thu Nov 15, 5:40 pm)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (..., Alexey Kuznetsov, (Mon Nov 19, 9:06 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (..., Bill Fink, (Tue Nov 20, 1:16 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, David Miller, (Tue Nov 20, 3:49 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, David Miller, (Thu Nov 15, 7:28 pm)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, Jonas Danielsson, (Fri Nov 16, 4:30 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, David Miller, (Fri Nov 16, 5:05 am)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, Bill Fink, (Fri Nov 16, 3:26 pm)
Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0, Jarek Poplawski, (Sat Nov 17, 6:14 pm)