Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Patrick McHardy

Subject: Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

Date: Wednesday, November 14, 2007 - 2:48 am

Rainer Jochem wrote:
quoted text> 
>> I don't think its very useful since you can simply get this information
>> from /proc/cmdline in case something goes wrong, but if you insist at
>> least give it a meaningful prefix.
> 
> Added.
> 
>> The initialization is unnecessary.
> 
> Removed.
> 
>> Should be >= I think.
> 
> Fixed.


Looks fine, thanks.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] ipconfig.c : implement DHCP Class-identifier, Rainer Jochem, (Thu Nov 8, 7:32 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Patrick McHardy, (Thu Nov 8, 8:45 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Ilpo Järvinen, (Thu Nov 8, 1:27 pm)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Rainer Jochem, (Wed Nov 14, 1:44 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Patrick McHardy, (Wed Nov 14, 1:56 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Rainer Jochem, (Wed Nov 14, 2:45 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Patrick McHardy, (Wed Nov 14, 2:48 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, David Miller, (Wed Nov 14, 3:18 am)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, Francois Romieu, (Wed Nov 14, 3:11 pm)

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier, David Miller, (Mon Nov 19, 10:56 pm)


linux-kernel:
Greg KH	Og dreams of kernels
Jarek Poplawski	Re: Network slowdown due to CFS
Srikar Dronamraju	[PATCH v2 11/11] Uprobes traceevents patch.
jimmy bahuleyan	Re: how about mutual compatibility between Linux's GPLv2 and GPLv3?
Greg KH	[003/129] xen: handle events as edge-triggered
git:
Eyvind Bernhardsen	Re: Where has "git ls-remote" reference pattern matching gone?
Junio C Hamano	Re: mingw, windows, crlf/lf, and git
Todd Zullinger	Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Shawn O. Pearce	Re: Switching from CVS to GIT
Santi Béjar	Re: How to use git-fmt-merge-msg?
git-commits-head:
Linux Kernel Mailing List	amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List	cpumask: make irq_set_affinity() take a const struct cpumask
Linux Kernel Mailing List	[Bluetooth] Make use of the default link policy settings
Linux Kernel Mailing List	x86/doc: mini-howto for using earlyprintk=dbgp
Linux Kernel Mailing List	geode lists are subscriber only
freebsd-current:
Michael Moll	Re: Unable to boot on ECS K7S5A
=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=	Re: Root exploit for FreeBSD
FreeBSD Tinderbox	[head tinderbox] failure on ia64/ia64
Andrew Thompson	Re: USB2 makes moused insane
Garrett Cooper	Re: linux 3d applications keep crashing
linux-netdev:
David Miller	Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Ramkrishna Vepa	[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Arnaud Ebalard	Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Florian Fainelli	[PATCH] cpmac: fix all checkpatch errors and warnings
Alexey Dobriyan	[PATCH v2 2/6] netns ct: per-netns /proc/net/stat/nf_conntrack , /proc/net/stat/ip...