Home » Mailing list archives » linux-netdev » 2007 » November » 13

[NET] random : secure_tcp_sequence_number should not assume CONFIG_KTIME_SCALAR

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric Dumazet <dada1@...>
To: David Miller <davem@...>
Cc: <netdev@...>, <kaber@...>, <stable@...>
Subject: [NET] random : secure_tcp_sequence_number should not assume CONFIG_KTIME_SCALAR
Date: Tuesday, November 13, 2007 - 9:41 am

I discovered one other incorrect use of .tv64 (coming from me, I must 
confess)

I guess this patch is  needed for 2.6.24 and stable (2.6.22 & 2.6.23)

Thank you

[NET] random : secure_tcp_sequence_number should not assume 
CONFIG_KTIME_SCALAR

All 32 bits machines but i386 dont have CONFIG_KTIME_SCALAR. On these 
machines, ktime.tv64
is more than 4 times the (correct) result given by ktime_to_ns()

Again on these machines, using ktime_get_real().tv64 >> 6 give a 32bits 
rollover every 64 seconds,
which is not wanted (less than the 120 s MSL)

Using ktime_to_ns() is the portable way to get nsecs from a ktime, and 
have correct code.


Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[NET] netfilter : xt_time should not assume CONFIG_KTIME_SCA..., Eric Dumazet, (Tue Nov 13, 7:30 am)
Re: [NET] netfilter : xt_time should not assume CONFIG_KTIME..., David Miller, (Tue Nov 13, 7:50 am)
[NET] random : secure_tcp_sequence_number should not assume ..., Eric Dumazet, (Tue Nov 13, 9:41 am)
Re: [stable] [NET] random : secure_tcp_sequence_number shoul..., Greg KH, (Wed Nov 14, 3:49 pm)
Re: [NET] random : secure_tcp_sequence_number should not ass..., David Miller, (Wed Nov 14, 1:13 am)
Re: [NET] netfilter : xt_time should not assume CONFIG_KTIME..., Patrick McHardy, (Tue Nov 13, 8:07 am)
Re: [NET] netfilter : xt_time should not assume CONFIG_KTIME..., Eric Dumazet, (Tue Nov 13, 8:48 am)
Re: [NET] netfilter : xt_time should not assume CONFIG_KTIME..., Patrick McHardy, (Tue Nov 13, 11:38 am)