Home » Mailing list archives » linux-netdev » 2007 » November » 13

[PATCH] Fix warning for token-ring from sysctl checker

Previous thread: [BUG] New Kernel Bugs by Natalie Protasevich on Tuesday, November 13, 2007 - 2:42 am. (153 messages)

Next thread: [PATCH] IPV4: add raw drops counter by Wang Chen on Tuesday, November 13, 2007 - 5:57 am. (11 messages)
[view original message]
From: Olof Johansson <olof@...>
To: <akpm@...>
Cc: <netdev@...>, <linux-kernel@...>, Eric W. Biederman <ebiederm@...>
Subject: [PATCH] Fix warning for token-ring from sysctl checker
Date: Tuesday, November 13, 2007 - 3:23 am

As seen when booting ppc64_defconfig:


sysctl table check failed: /net/token-ring .3.14 procname does not match binary path procname


Signed-off-by: Olof Johansson <olof@lixom.net>


diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c

index 5a2f2b2..4abc6d2 100644

--- a/kernel/sysctl_check.c

+++ b/kernel/sysctl_check.c

@@ -738,7 +738,7 @@ static struct trans_ctl_table trans_net_table[] = {

 	{ NET_ROSE,		"rose",		trans_net_rose_table },

 	{ NET_IPV6,		"ipv6",		trans_net_ipv6_table },

 	{ NET_X25,		"x25",		trans_net_x25_table },

-	{ NET_TR,		"tr",		trans_net_tr_table },

+	{ NET_TR,		"token-ring",	trans_net_tr_table },

 	{ NET_DECNET,		"decnet",	trans_net_decnet_table },

 	/*  NET_ECONET not used */

 	{ NET_SCTP,		"sctp",		trans_net_sctp_table },

-
[view original message]
From: David Miller <davem@...>
To: <olof@...>
Cc: <akpm@...>, <netdev@...>, <linux-kernel@...>, <ebiederm@...>
Subject: Re: [PATCH] Fix warning for token-ring from sysctl checker
Date: Wednesday, November 14, 2007 - 1:15 am

From: Olof Johansson <olof@lixom.net>


Patch applied, thanks Olof.

-
[view original message]
From: Eric W. Biederman <ebiederm@...>
To: David Miller <davem@...>
Cc: <olof@...>, <akpm@...>, <netdev@...>, <linux-kernel@...>
Subject: Re: [PATCH] Fix warning for token-ring from sysctl checker
Date: Wednesday, November 14, 2007 - 11:56 am

No objections but I think we already have this fixed in the -mm tree.


Eric


-
[view original message]
From: Randy Dunlap <randy.dunlap@...>
To: Eric W. Biederman <ebiederm@...>
Cc: David Miller <davem@...>, <olof@...>, <akpm@...>, <netdev@...>, <linux-kernel@...>
Subject: Re: [PATCH] Fix warning for token-ring from sysctl checker
Date: Wednesday, November 14, 2007 - 12:45 pm

Yes, I patched it several weeks ago and it's been in -mm for a while

now.  Apparently too long.


---

~Randy

-
[view original message]
From: Olof Johansson <olof@...>
To: Randy Dunlap <randy.dunlap@...>
Cc: Eric W. Biederman <ebiederm@...>, David Miller <davem@...>, <akpm@...>, <netdev@...>, <linux-kernel@...>
Subject: Re: [PATCH] Fix warning for token-ring from sysctl checker
Date: Wednesday, November 14, 2007 - 8:28 pm

Ah, sorry for the duplicate patch then. I must have missed it at the

original posting (and didn't search that far back and/or -mm before

posting it myself).


-Olof

-
[view original message]
From: Eric W. Biederman <ebiederm@...>
To: Olof Johansson <olof@...>
Cc: Randy Dunlap <randy.dunlap@...>, David Miller <davem@...>, <akpm@...>, <netdev@...>, <linux-kernel@...>
Subject: Re: [PATCH] Fix warning for token-ring from sysctl checker
Date: Wednesday, November 14, 2007 - 9:12 pm

As long as the patch gets merged and makes it's way upstream so people

can use the token-ring code I don't really care who posts it.


Eric

-
Previous thread: [BUG] New Kernel Bugs by Natalie Protasevich on Tuesday, November 13, 2007 - 2:42 am. (153 messages)

Next thread: [PATCH] IPV4: add raw drops counter by Wang Chen on Tuesday, November 13, 2007 - 5:57 am. (11 messages)