Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Tuesday, October 9, 2007 - 9:51 am

David Miller <davem@davemloft.net> writes:

Hopefully that new qdisc will just use the TX rings of the hardware
directly. They are typically large enough these days. That might avoid
some locking in this critical path.


I agree. For most interfaces the priority is probably dubious.
Even for DSL the prioritization will be likely usually done in a router
these days.

Also for the fast interfaces where we do TSO priority doesn't work
very well anyways -- with large packets there is not too much 
to prioritize.


If the data is just passed on to the hardware queue, why is any 
locking needed at all? (except for the driver locking of course)

-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/3][NET_BATCH] net core use batching, jamal, (Mon Oct 8, 11:26 am)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Waskiewicz Jr, Peter P, (Mon Oct 8, 12:46 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 2:26 pm)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Waskiewicz Jr, Peter P, (Mon Oct 8, 3:33 pm)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Waskiewicz Jr, Peter P, (Mon Oct 8, 3:36 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Mon Oct 8, 6:13 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Mon Oct 8, 6:31 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 6:41 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:01 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:03 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:04 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Mon Oct 8, 7:12 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:16 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:16 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:20 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 7:43 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 7:45 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Mon Oct 8, 7:46 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 7:46 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Mon Oct 8, 7:47 pm)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Krishna Kumar2, (Tue Oct 9, 3:58 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Tue Oct 9, 4:02 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Krishna Kumar2, (Tue Oct 9, 4:20 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Krishna Kumar2, (Tue Oct 9, 4:21 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Tue Oct 9, 4:24 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Tue Oct 9, 5:44 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Herbert Xu, (Tue Oct 9, 5:55 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Tue Oct 9, 6:00 am)
Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Andi Kleen, (Tue Oct 9, 9:51 am)
Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Stephen Hemminger, (Tue Oct 9, 11:22 am)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Waskiewicz Jr, Peter P, (Tue Oct 9, 11:48 am)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Tue Oct 9, 12:04 pm)
RE: [PATCH 2/3][NET_BATCH] net core use batching, Waskiewicz Jr, Peter P, (Tue Oct 9, 12:07 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Tue Oct 9, 1:14 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Jeff Garzik, (Tue Oct 9, 1:20 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Roland Dreier, (Tue Oct 9, 1:22 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Tue Oct 9, 1:51 pm)
Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Stephen Hemminger, (Tue Oct 9, 1:53 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, David Miller, (Tue Oct 9, 2:25 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Roland Dreier, (Tue Oct 9, 2:40 pm)
Re: [PATCH 2/3][NET_BATCH] net core use batching, Roland Dreier, (Tue Oct 9, 3:44 pm)
[PATCH 1/4] IPoIB: Fix unused variable warning, Roland Dreier, (Tue Oct 9, 3:46 pm)
[PATCH 3/4] ibm_new_emac: Nuke SET_MODULE_OWNER() use, Roland Dreier, (Tue Oct 9, 3:47 pm)
Re: [PATCH 1/4] IPoIB: Fix unused variable warning, David Miller, (Tue Oct 9, 4:17 pm)
Re: [PATCH 1/4] IPoIB: Fix unused variable warning, Jeff Garzik, (Tue Oct 9, 5:32 pm)
Re: [PATCH 1/4] IPoIB: Fix unused variable warning, Jeff Garzik, (Tue Oct 9, 5:47 pm)
RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Waskiewicz Jr, Peter P, (Wed Oct 10, 8:35 am)
RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Waskiewicz Jr, Peter P, (Wed Oct 10, 9:42 am)
RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Brandeburg, Jesse, (Fri Oct 12, 9:08 am)
Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use ..., Stephen Hemminger, (Fri Oct 12, 10:05 am)