On Sun, 2007-07-10 at 23:32 -0700, David Miller wrote:

quoted text
> This "cleanup" only makes sense if we go with your TX batching
> interfaces.
>
> They make the TX batching support patch for this driver "nice" and
> "clean", but it makes zero sense in any other context.  
> In fact, it
> adds more memory references in the TX pacth, and in fact does so by
> adding usage of the skb->cb[] which the driver didn't need to do
> previously.
> 
> So I'm going to hold off on this one for now, keep it in your TX
> batching changes instead.

The batching benefits from it because it reuses code. But i would put
readability as something of no value. 
In any case i would defer this for later.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html