On Wed, 31 Oct 2007 14:54:06 -0700 (PDT) -

On Wed, 31 Oct 2007 14:35:56 -0700 (PDT) -

While cleaning up the internal API focussing on Fiber and CX4 code we found that I had broken the copper PHY initialization code. This patch restores the PHY-specific code. This is mostly uninteresting since no copper PHY boards are yet available. The changes have been tested against Fiber only as I do not even have copper PHY versions of 82598 macs. This change actually cleans up the API code a bit more and we lose some initialization code. A few PHY link detection helper lines of code have been ...

L1 ASPM link (pci-e link power savings) has significant benefits (~1W savings when link is active) but unfortunately does not work correctly on any of the chipsets that have 82573 on mobile platforms which causes various nuisances: - eeprom reads return garbage information leading to bad eeprom checksums - long ping times (up to 2 seconds) - complete system hangs (freeze/lockup) A lot of T60 owners have been plagued by this, but other mobile solutions also suffer from these symptoms. Dis...

On Wed, 31 Oct 2007 17:40:06 -0400 Yes, this looks right. How could the check in netif_rx_complete be changed to catch this better? -- Stephen Hemminger <shemminger@linux-foundation.org> -

Convert REG_PATTERN_TEST and REG_SET_AND_CHECK macros to functions Reduces x86 defconfig image by about 3k compiled, untested (no hardware) Signed-off-by: Joe Perches <joe@perches.com> New: $ size vmlinux text data bss dec hex filename 4792735 490626 606208 5889569 59de21 vmlinux Current: $ size vmlinux text data bss dec hex filename 4795759 490626 606208 5892593 59e9f1 vmlinux --- drivers/net/e1000/e1000_ethtool.c | 185 ++++++++...

You could define something like: #define REG_PATTERN_TEST(reg, mask, write) \ if (reg_pattern_test(adapter, data, \ E1000_REG(&adapter->hw, reg), \ mask, write)) \ return 1; No. Your choice to keep/remove. Simple enough. When is e1000e scheduled to be part of defconfig? cheers, Joe -

For the 3 lines above, how about: * Return values (usually ignored): * NET_RX_SUCCESS: no congestion * NET_RX_DROP: packet was dropped only because they come out of kernel-doc badly, munged together like so: return values (usually ignored). NET_RX_SUCCESS (no congestion) Thanks for doing this patch. --- ~Randy -

On Wed, 31 Oct 2007 14:43:51 -0400 The VLAN acceleration grabs and hides the tag. It is a design flaw that should be fixed, feel free to post a patch. -- Stephen Hemminger <shemminger@linux-foundation.org> -

Did you had time to check the impact of your patch with the rest of the network namespaces not yet included in mainline, belonging to Eric's git tree ? ps: can you cc' emails concerning the network namespace to the containers mailing list too ? thx. -

Really? Have you actually measured that? If the overhead is measurable and expensive we may want to look at per cpu counters or something like that. So far I don't have any numbers that say any Well that extra check should be removed once we finish converting those code paths. So I'm not too worried. If this becomes a big issue I can dig up my old code that replaced struct net * with a net_t typedef and used functions for all of the comparisons and allowed everything to be compiled away. ...

From: Eric Dumazet <dada1@cosmosbay.com> P4 chips are generally very poor at mispredicted branches and atomics. So every atomic you remove from the socket paths gives a noticable improvement on them. Network device reference counting is such a stupid problem. There has to be a way to get rid of it on the packet side. I think we could get rid of all of the device refcounting from packets if we: 1) Formalize "SKB roots". This is every place a packet could sit in the transmit path....

This cache is only required to create new namespaces, but we won't have them in CONFIG_NET_NS=n case. Hide it under the appropriate ifdef. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index a044e2d..e9f0964 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -17,8 +17,6 @@ static DEFINE_MUTEX(net_mutex); LIST_HEAD(net_namespace_list); -static struct kmem_cache *net_cachep; - struc...

The namespace creation/destruction code is never called if the CONFIG_NET_NS is n, so it's OK to move it under appropriate ifdef. The copy_net_ns() in the "n" case checks for flags and returns -EINVAL when new net ns is requested. In a perfect world this stub must be in net_namespace.h, but this function need to know the CLONE_NEWNET value and thus requires sched.h. On the other hand this header is to be injected into almost every .c file in the networking code, and making all this code depend on...

When the new pernet something (subsys, device or operations) is being registered, the init callback is to be called for each namespace, that currently exitst in the system. During the unregister, the same is to be done with the exit callback. However, not every pernet something has both calls, but the check for the appropriate pointer to be not NULL is performed inside the for_each_net() loop. This is (at least) strange, so tune this. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> ...

... Your mail to 'Tlan-devel' with the subject drivers/net/tlan question Is being held until the list moderator can review it for approval. The reason it is being held: Post by non-member to a members-only list ... Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com> --- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4a26f83..6a116f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ ...

From: Patrick McHardy <kaber@trash.net> Thanks for bringing up this topic. Instead of answering your questions, I'm going to show you how to avoid having to do any of this cache flushing crap :-) You can avoid having to flush anything as long as the virtual addresses on the kernel side are modulo SHMLBA the virtual addresses on the userland side. We have some (decidedly awkward) mechanisms to try and achieve this in the kernel, but they are cumbersome and not air tight. Instead, I w...

for the series: Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Haven't tested, but it looks straightforward and conceptually sound, thanks for improving the sk_prot infrastructure! :-) Now we have just to make all the other protocols fill in the missing sk->sk_prot-> methods (converting what is there now in socket->ops) so that we can kill socket->ops and eliminate one level of indirection :-P - Arnaldo -

Start here: const struct proto_ops inet_stream_ops = { .family = PF_INET, .owner = THIS_MODULE, .release = inet_release, .bind = inet_bind, .connect = inet_stream_connect, .socketpair = sock_no_socketpair, .accept = inet_accept, .getname = inet_getname, .poll = tcp_poll, .ioctl = inet_ioctl, .liste...

At this point nobody calls the sk_alloc(() with zero_it == 0, so remove unneeded checks from it. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/core/sock.c b/net/core/sock.c index c032f48..77575c3 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -931,21 +931,16 @@ struct sock *sk_alloc(struct net *net, int family, gfp_t priority, { struct sock *sk; - if (zero_it) - priority |= __GFP_ZERO; - - sk = sk_prot_alloc(prot, priority, family); + sk = sk...

The security_sk_alloc() and the module_get is a part of the object allocations - move it in the proper place. Note, that since we do not reset the newly allocated sock in the sk_alloc() (memset() is removed with the previous patch) we can safely do this. Also fix the error path in sk_prot_alloc() - release the security context if needed. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/core/sock.c b/net/core/sock.c index 21fc79b..e7537e4 100644 --- a/net/core...

The sock object is allocated either from the generic cache with the kmalloc, or from the proc->slab cache. Move this logic into an isolated set of helpers and make the sk_alloc/sk_free look a bit nicer. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/core/sock.c b/net/core/sock.c index 9c2dbfa..7c2e3db 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -870,6 +870,31 @@ static void sock_copy(struct sock *nsk, const struct sock *osk) #endif } +stat...

The sock_copy() call is not used outside the sock.c file, so just move it into a sock.c Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/include/net/sock.h b/include/net/sock.h index 43fc3fa..ecad7b4 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -993,20 +993,6 @@ static inline void sock_graft(struct sock *sk, struct socket *parent) write_unlock_bh(&sk->sk_callback_lock); } -static inline void sock_copy(struct sock *nsk, const struct sock *o...

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi> I will queue this bug fix up, thanks Ilpo! And thanks for all of the testing information, it helps review enormously. -

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi> I'll apply this also, thanks a lot. -