Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device? | KernelTrap

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Stephen Hemminger <shemminger@...>

To: Dave Johnson <djohnson+linux-kernel@...>

Cc: <linux-kernel@...>, <netdev@...>, Bin Guo <bguo@...>

Subject: Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

Date: Wednesday, October 31, 2007 - 3:33 pm

On Wed, 31 Oct 2007 14:43:51 -0400
Dave Johnson <djohnson+linux-kernel@sw.starentnetworks.com> wrote:

quoted text> 
> Depending on the network driver, I'm seeing different behavior if
> a .1q packet is received to an PF_PACKET, SOCK_RAW, ETH_P_ALL socket.
> 
> 
> On devices what do not use NETIF_F_HW_VLAN_RX, the packet socket gets
> the complete packet with vlan tag included as the driver simply calls
> netif_receive_skb() or equivilant.  packet_rcv() then gets the whole
> thing vlan tag included and sends this through the socket.
> 
> vlan_skb_recv() also gets these all and will drop them because there
> are no vlans configured.
> 

The VLAN acceleration grabs and hides the tag. It is a design flaw
that should be fixed, feel free to post a patch.


-- 
Stephen Hemminger <shemminger@linux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?, Dave Johnson, (Wed Oct 31, 2:43 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Stephen Hemminger, (Wed Oct 31, 3:33 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Ben Greear, (Wed Oct 31, 9:06 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Stephen Hemminger, (Wed Oct 31, 9:23 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Thu Nov 1, 12:50 am)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Ben Greear, (Thu Nov 1, 11:04 am)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Dave Johnson, (Thu Nov 1, 5:36 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Dave Johnson, (Fri Nov 2, 2:08 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Fri Nov 2, 5:20 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Michael Chan, (Fri Nov 2, 5:52 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Thu Nov 1, 5:58 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Rick Jones, (Thu Nov 1, 5:48 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Thu Nov 1, 5:59 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Rick Jones, (Thu Nov 1, 6:04 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Thu Nov 1, 6:07 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Rick Jones, (Thu Nov 1, 7:26 pm)

[PATCH 2/2] NET: Re-add VLAN tag for devices incapable of ke..., Dave Johnson, (Mon Nov 5, 1:47 pm)

RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable o..., Ramkrishna Vepa, (Mon Nov 5, 10:39 pm)

RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable o..., Ramkrishna Vepa, (Tue Nov 6, 2:28 pm)

RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable o..., Dave Johnson, (Tue Nov 6, 2:34 pm)

[PATCH 1/2] NET: Re-add VLAN tag for devices incapable of ke..., Dave Johnson, (Mon Nov 5, 1:46 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Patrick McHardy, (Mon Nov 5, 2:00 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., David Miller, (Mon Nov 5, 7:15 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Patrick McHardy, (Mon Nov 5, 8:21 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Krzysztof Halasa, (Tue Nov 6, 2:03 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Patrick McHardy, (Tue Nov 6, 7:55 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Ben Greear, (Tue Nov 6, 2:56 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., Krzysztof Halasa, (Tue Nov 6, 4:08 pm)

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable o..., David Miller, (Mon Nov 5, 8:35 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Thu Nov 1, 5:35 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., Ben Greear, (Wed Oct 31, 9:31 pm)

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX dev..., David Miller, (Wed Oct 31, 9:10 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Joerg Roedel	[PATCH 03/34] AMD IOMMU: add defines and structures for ACPI scanning code
Ingo Molnar	[patch 03/13] syslets: generic kernel bits
Greg KH	Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interface for on access scan...
git:

linux-netdev:

Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 2 users and 951 guests online.

Online users

Syndicate