Home » Mailing list archives » linux-netdev » 2007 » October » 3

[PATCH net-2.6.24 0/3]: More TCP fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ilpo Järvinen
Subject: [PATCH net-2.6.24 0/3]: More TCP fixes
Date: Wednesday, October 3, 2007 - 4:00 am

Hi Dave,

Sacktag fastpath_cnt_hint seems to be very tricky to get right...
I suppose this one fixes Cedric's case. I cannot say for sure    
until there is something more definite indication of
tcp_retrans_try_collapse origin than what the simple late WARN_ON
gave for us. ...Especially since it's non-trivial to have skb
hint "correctly" positioned in the write_queue while still ending
up calling that function. However, considering how difficult it
seems to be for Cedric to reproduce, it might well be this one.

In addition, I noticed another reset which wasn't previously   
converted to WARN_ON, so doing that now. Boot + simple xfer
tested. Please apply to net-2.6.24.

--
 i.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 4:00 am)
[PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_ou ..., Ilpo Järvinen, (Wed Oct 3, 4:00 am)
[PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap, Ilpo Järvinen, (Wed Oct 3, 4:00 am)
[PATCH 3/3] [TCP]: "Annotate" another fackets_out state reset, Ilpo Järvinen, (Wed Oct 3, 4:00 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 4:58 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 5:34 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 5:48 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 6:19 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 7:05 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 7:22 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 7:58 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 7:59 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 8:12 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Thu Oct 4, 3:13 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Thu Oct 4, 7:53 am)
[PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO s ..., Ilpo Järvinen, (Thu Oct 4, 1:20 pm)
Re: [PATCH 1/3] [TCP]: Fix two off-by-one errors in facket ..., David Miller, (Sun Oct 7, 11:36 pm)
Re: [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-on ..., David Miller, (Sun Oct 7, 11:37 pm)
Re: [PATCH 3/3] [TCP]: "Annotate" another fackets_out stat ..., David Miller, (Sun Oct 7, 11:38 pm)
Re: [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when G ..., David Miller, (Sun Oct 7, 11:39 pm)