Home » Mailing list archives » linux-netdev » 2007 » October » 3

[PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ilpo Järvinen <ilpo.jarvinen@...>
To: David Miller <davem@...>, Cedric Le Goater <legoater@...>
Cc: <netdev@...>
Subject: [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic
Date: Wednesday, October 3, 2007 - 7:00 am

1) Passing wrong skb to tcp_adjust_fackets_out could corrupt
fastpath_cnt_hint as tcp_skb_pcount(next_skb) is not included
to it if hint points exactly to the next_skb (it's lagging
behind, see sacktag).

2) When fastpath_skb_hint is put backwards to avoid dangling
skb reference, the skb's pcount must also be removed from count
(not included like above).

Reported by Cedric Le Goater <legoater@free.fr>

Signed-off-by: Ilpo J
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 7:00 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 7:58 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 8:34 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 8:48 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 9:19 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 10:05 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Wed Oct 3, 10:22 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 10:58 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 11:12 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Ilpo Järvinen, (Thu Oct 4, 6:13 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Thu Oct 4, 10:53 am)
[PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb..., Ilpo Järvinen, (Thu Oct 4, 4:20 pm)
Re: [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO..., David Miller, (Mon Oct 8, 2:39 am)
Re: [PATCH net-2.6.24 0/3]: More TCP fixes, Cedric Le Goater, (Wed Oct 3, 10:59 am)
[PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out ..., Ilpo Järvinen, (Wed Oct 3, 7:00 am)
Re: [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_..., David Miller, (Mon Oct 8, 2:36 am)
[PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap, Ilpo Järvinen, (Wed Oct 3, 7:00 am)
Re: [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one ..., David Miller, (Mon Oct 8, 2:37 am)
[PATCH 3/3] [TCP]: "Annotate" another fackets_out state reset, Ilpo Järvinen, (Wed Oct 3, 7:00 am)
Re: [PATCH 3/3] [TCP]: "Annotate" another fackets_out state ..., David Miller, (Mon Oct 8, 2:38 am)