[RFC] remove netpoll receive code

Previous thread: Re: multicast: bug or "feature" by Vlad Yasevich on Wednesday, October 17, 2007 - 4:19 pm. (1 message)

Next thread: Re: [Bugme-new] [Bug 9179] New: 2.6.23.1 / USB_ZD1201: Kernel panic with zd1201 driver by Andrew Morton on Wednesday, October 17, 2007 - 4:27 pm. (4 messages)
To: David S. Miller <davem@...>, Andrew Morton <akpm@...>
Cc: <netdev@...>, <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 4:21 pm

The netpoll receive code is:
1. Not used by any in-tree features, it is used by kgdb-over-ether.
2. A nice hook for people doing nasty things like private binary network stacks or rootkits.
3. Unsecured by any of the normal firewalling code.

Hopefully all distro's are smart enough to turn it off in their default config *nudge, nudge*.
Doubly true for any distribution that claims to be secure or enterprise ready.

I propose that we take out all the whole netpoll rx path. If/when kgdb gets submitted
a better and alternative receive path can be added.

--
Stephen Hemminger <shemminger@linux-foundation.org>
-

To: Stephen Hemminger <shemminger@...>
Cc: David S. Miller <davem@...>, Andrew Morton <akpm@...>, <netdev@...>, <linux-kernel@...>
Date: Monday, October 22, 2007 - 12:54 pm

[annoyed as ever about never being cc:ed on this stuff]

It's a completely useless hook for a binary network stack. It only
supports UDP and only point to point. And it will have crap
performance. It's much less useful here than, say, TUN/TAP.

It doesn't buy anything for a rootkit either, which will continue to
trivially hide servers in userspace as they already do.

This is correct. It also applies to the TX side of things. The point,
of course, is to bypass as much of the stack as possible so that when
the kernel crashes, we're more likely to actually get our netpoll

Let's hear about this better alternative first, shall we? I for one am
a little skeptical of its existence. Going through a larger fraction
of the network stack, running softirqs, etc., are all big (potentially
fatal) steps backward from the point of view of a debugger.

--
Mathematics is the supreme nostalgia of our time.
-

To: <shemminger@...>
Cc: <akpm@...>, <netdev@...>, <linux-kernel@...>
Date: Thursday, October 18, 2007 - 2:28 am

From: Stephen Hemminger <shemminger@linux-foundation.org>

I would like to kill the RX side handling of netpoll too,
but I don't think that's reasonable as kgdb is actively
being pushed for 2.6.25 inclusion.

Andrew is likely to add it to his -mm tree soon and therefore kgdb
will need to work properly now.

The RX netpoll thing has a long precedence, it's been in the tree for
a long time, so we are in some ways stuck with it until we have a
complete replacement facility. That means we can't yank it out first
and implement the replacement later.
-

To: David Miller <davem@...>
Cc: <shemminger@...>, <netdev@...>, <linux-kernel@...>, Jason Wessel <jason.wessel@...>
Date: Thursday, October 18, 2007 - 3:02 am

git-kgdb.patch has been in there for ages - maybe a year. Although I
disabled it a week or so ago due to the sheer number of rejects. Will
-

To: Andrew Morton <akpm@...>
Cc: David Miller <davem@...>, <netdev@...>, <linux-kernel@...>, Jason Wessel <jason.wessel@...>
Date: Thursday, October 18, 2007 - 11:25 am

On Thu, 18 Oct 2007 00:02:44 -0700

How about I work on a better/alternative receive path for kgdb that
can be applied after kgdb is included. Kgdb could actually be useful
for me :-)

--
Stephen Hemminger <shemminger@linux-foundation.org>
-

To: Stephen Hemminger <shemminger@...>
Cc: David S. Miller <davem@...>, Andrew Morton <akpm@...>, <netdev@...>, <linux-kernel@...>
Date: Wednesday, October 17, 2007 - 11:52 pm

Kgdb has been submitted for inclusion in the mainline kernel at this
point, along with an additional change to the netpoll rx path.

If it is the case that this needs to be implemented in another manner,
that is ok but please do let me know what the plans are for the API so
that the kgdboe code can be adapted.

Thanks,
Jason.

-

To: Stephen Hemminger <shemminger@...>
Cc: <davem@...>, <netdev@...>, <linux-kernel@...>, Jason Wessel <jason.wessel@...>
Date: Wednesday, October 17, 2007 - 4:41 pm

On Wed, 17 Oct 2007 13:21:31 -0700

umm, let's cc the kgdb maintainer.
-

Previous thread: Re: multicast: bug or "feature" by Vlad Yasevich on Wednesday, October 17, 2007 - 4:19 pm. (1 message)

Next thread: Re: [Bugme-new] [Bug 9179] New: 2.6.23.1 / USB_ZD1201: Kernel panic with zd1201 driver by Andrew Morton on Wednesday, October 17, 2007 - 4:27 pm. (4 messages)