Re: [KVM-AUTOTEST][PATCH 2/2][virtio-console] Fix compatibility with python 2.4.

Previous thread: Performance test result between per-vhost kthread disable and enable by lidong chen on Monday, November 22, 2010 - 7:13 pm. (12 messages)

Next thread: Performance test result between virtio_pci MSI-X disable and enable by lidong chen on Monday, November 22, 2010 - 7:53 pm. (21 messages)
From: Amos Kong
Date: Monday, November 22, 2010 - 7:30 pm

After loading your this patch, virtio_console also could not work with older python.

Something are not fixed, such as:
  "return True if self.failed > 0 else False"
  "PASS"if result[0] else "FAIL"
  ...

--

From: Lukáš Doktor
Date: Thursday, November 25, 2010 - 9:22 am

Hi,

this fixes only the GUEST (virtio_guest.py) side of the virtio_console 
test. (tested with python 2.4.3 and 2.4.6)

It's possible to fix the host side too but distributions which supports 
only python 2.4 usually supports older versions of KVM without the 
'-device' option we use in the HOST side of the test for creating the 
devices. This change would only make the code less readable with minimal 
income.

Anyway if there's a real demand, we can fix the HOST side too.

Cheers,

--

From: Lucas Meneghel Rodrigues
Date: Thursday, November 25, 2010 - 12:04 pm

The point here is that we're under a larger project, autotest, which
strives to keep py 2.4 compatibility. So yes, we're going to need to fix
the host side too. However, I'd like to point out that you guys have
done an excellent job with the virtio_console test, great code quality.

Cheers,



--

Previous thread: Performance test result between per-vhost kthread disable and enable by lidong chen on Monday, November 22, 2010 - 7:13 pm. (12 messages)

Next thread: Performance test result between virtio_pci MSI-X disable and enable by lidong chen on Monday, November 22, 2010 - 7:53 pm. (21 messages)