Re: [PATCHv4 15/15] Pass boot device list to firmware.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Blue Swirl
Date: Sunday, November 14, 2010 - 3:50 pm

On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov <gleb@redhat.com> wrote:

This should be
#define FW_CFG_MAX_ENTRY        (FW_CFG_BOOTINDEX + 1)
because the check is like this:
    if ((key & FW_CFG_ENTRY_MASK) >= FW_CFG_MAX_ENTRY) {
        s->cur_entry = FW_CFG_INVALID;

With that change, I got the bootindex passed to OpenBIOS:
OpenBIOS for Sparc64
Configuration device id QEMU version 1 machine id 0
kernel cmdline
CPUs: 1 x SUNW,UltraSPARC-IIi
UUID: 00000000-0000-0000-0000-000000000000
bootindex num_strings 1
bootindex /pbm@000001fe00000000/ide@5/drive@1/disk@0

The device path does not match exactly, but it's close:
/pci@1fe,0/pci-ata@5/ide1@600/disk@0
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv4 00/15] boot order specification, Gleb Natapov, (Sun Nov 14, 8:39 am)
[PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Sun Nov 14, 8:39 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Sun Nov 14, 11:41 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Sun Nov 14, 11:52 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Sun Nov 14, 1:54 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Sun Nov 14, 1:56 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Sun Nov 14, 1:57 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Sun Nov 14, 2:45 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Blue Swirl, (Sun Nov 14, 3:50 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Kevin O'Connor, (Sun Nov 14, 8:40 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Mon Nov 15, 12:40 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Mon Nov 15, 12:53 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Mon Nov 15, 1:09 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Mon Nov 15, 1:42 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Kevin O'Connor, (Mon Nov 15, 6:26 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Mon Nov 15, 6:36 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Mon Nov 15, 6:46 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Kevin O'Connor, (Mon Nov 15, 7:52 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Tue Nov 16, 12:22 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Kevin O'Connor, (Tue Nov 16, 6:49 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Tue Nov 16, 7:11 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Blue Swirl, (Tue Nov 16, 11:19 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Blue Swirl, (Tue Nov 16, 11:30 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Tue Nov 16, 12:02 pm)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Thu Nov 18, 3:18 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Thu Nov 18, 4:38 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Thu Nov 18, 4:45 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Thu Nov 18, 4:52 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Thu Nov 18, 5:16 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Thu Nov 18, 5:23 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Thu Nov 18, 5:37 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Michael S. Tsirkin, (Thu Nov 18, 6:12 am)
Re: [PATCHv4 15/15] Pass boot device list to firmware., Gleb Natapov, (Thu Nov 18, 6:16 am)