Home » Mailing list archives » linux-kvm » 2009 » July

linux-kvm mailing list

FromSubjectsort iconDate
Jan Kiszka
[PATCH] qemu-kvm: Fix kvm-disabled build

This addresses all issues that currently block building qemu-kvm with
kvm support switched off. It's a pragmatic approach as more cleanups
are actually required /wrt {kvm,libkvm,qemu-kvm}.h.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

hw/pcspk.c | 4 ++--
libkvm-all.h | 8 ++++++++
qemu-kvm.h | 3 ++-
3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/hw/pcspk.c b/hw/pcspk.c
index 9e1b59a..3d3eba4 100644
--- a/hw/pcspk.c
+++ b/hw/pcspk.c
@@ -82,9...

[ message continues ]

Jul 4, 5:03 am 2009
Jan Kiszka
[PATCH] qemu-kvm: Fix warning with DEVICE_ASSIGNMENT disabled

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

hw/pci-hotplug.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index 66fa377..1180758 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -256,7 +256,9 @@ void pci_device_hot_remove_success(int pcibus, int sl=
ot)
{
PCIDevice *d =3D pci_find_device(pcibus, slot, 0);
int class_code;
+#ifdef USE_KVM_DEVICE_ASSIGNMENT
AssignedDevInfo *adev;
+#endif
...

[ message continues ]

Jul 4, 5:00 am 2009
Avi Kivity
Re: [RFC] allow multi-core guests: introduce cores= option t...

I thought of using -smp [processors=]2,cores=4,threads=2 (for a total of
16 threads), but I think it makes more sense with -cpu.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--

Jul 4, 11:25 am 2009
Paul Brook
Re: [Qemu-devel] [RFC] allow multi-core guests: introduce co...

I disagree. I think it makes a sense of the topology of nodes, cores and
threads to all be specified in the same place. All the options you don't
specify should have sensible defaults.

Paul
--

Jul 4, 1:58 am 2009
Gleb Natapov
Re: [Qemu-devel] Re: [RFC] allow multi-core guests: introduc...

There is not point in [,sockets=1] option -smp socketnum[,cores=n][,threads=n]
is backwards compatible already if default for cores and threads is 1.
I have a similar patch locally that does that. What I think is missing
for KVM (and in the future for QEMU) is hotplug support. The current
hotplug code can't hotplug the socket, only one vcpu. What is missing is
the ability to specify number of available sockets vs number of
populated sockets and specify base apic id for each available socket.
Cpu ho...

[ message continues ]

Jul 4, 3:18 am 2009
Jamie Lokier
Re: [Qemu-devel] Re: [RFC] allow multi-core guests: introduc...

Why is the number of vCPUs required at all?

-smp cores=2,threads=2

The "4" is redundant.

-- Jamie
--

Jul 3, 8:04 pm 2009
Avi Kivity
Re: [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack

It's necessary for backwards compatibility. Older kvm versions
misreported these bits, so we need to fix them up in userspace.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--

Jul 4, 11:21 am 2009
G
Re: KVM crashes when using certain USB device

Good idea. The results from three test runs after that change are in
the attached files. The third was done while also dumping the USB bus,
and the output from that dump is also attached.

Jul 4, 6:01 am 2009
Avi Kivity
Re: [PATCH v5] enable x2APIC without interrupt remapping und...

The kvm tree won't depend on this change. I'm happy with it going into
2.6.32 via tip.git.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--

Jul 4, 11:20 am 2009
Eric W. Biederman
Re: [PATCH v5] enable x2APIC without interrupt remapping und...

Please don't separate the x2apic code from the dmar code for this
reason.

Supporting hotplug cpus with ioapics is torture.

Eric
--

Jul 4, 5:35 am 2009
Gleb Natapov
Re: [PATCH v5] enable x2APIC without interrupt remapping und...

What is the connection between this patch and cpu hotplug?

--
Gleb.
--

Jul 4, 5:55 am 2009
Eric W. Biederman
Re: [PATCH v5] enable x2APIC without interrupt remapping und...

When I asked if cpu hotplug was a supported and more or
less common feature of kvm I was told it was.

Good cpu hotplug today means supporting interrupt remapping.
(The code you are disabling for kvm).

Therefore I don't see the point of supporting one without the other.
Especially if we don't have a case where on real hardware we need to
split the support.

Eric
--

Jul 4, 10:33 am 2009
Gleb Natapov
Re: [PATCH v5] enable x2APIC without interrupt remapping und...

It is supported in a sense that cpus can be created dynamically
and DSDT has objects to inform OS that a cpu state changed. I don't
know how common it is. I surely don't use it daily. But 99% of the real
From you previous mails I understand that the problem is no with cpu
hotplug, but with cpu offlining and this is the guest feature that
cannot be controlled by KVM in any way. If you think that Linux should
not support cpu offlining with ioapics fine, send a patch to disable it
and cpu hot-unplug wil...

[ message continues ]

Jul 4, 11:50 am 2009
previous daytodaynext day
July 3, 2009July 4, 2009July 5, 2009