Home » Mailing list archives » linux-kvm » 2009 » July » 3

Re: [Autotest] [PATCH] Add a client-side test qemu_iotests

Previous thread: KVM: PIT: fix kpit_elapsed division by zero by Marcelo Tosatti on Thursday, July 2, 2009 - 7:02 pm. (2 messages)

Next thread: KVM-87 Compile warnings on 64-bit Jaunty by Randy Smith on Friday, July 3, 2009 - 12:38 am. (1 message)
[view original message]
From: Lucas Meneghel Rodrigues <lmr@...>
To: Yolkfull Chow <yzhou@...>
Cc: <autotest@...>, sudhir kumar <smalikphy@...>, <kvm@...>, Martin Bligh <mbligh@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Thursday, July 2, 2009 - 8:23 pm

Ok, I've been trough the test and took a look at the testsuite itself.

Both look good. The testsuite requires a very current qemu-img package,

due to the use of qemu-io (F11 for instance doesn't ship it). So if you

want to try this make sure you use a current version of the kvm

utilities.


+1


Lucas


--
[view original message]
From: Lucas Meneghel Rodrigues <lmr@...>
To: Yolkfull Chow <yzhou@...>
Cc: <autotest@...>, <kvm@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Friday, July 3, 2009 - 1:03 am

It just occurred to me some suggestions based on my last comment:

 * Make sure we have the qemu, qemu-img and the qemu-io ELF files

available to execute the test suite, and if we doesn't, raise a

error.TestError() exception.

 * Make it possible to specify an alternate prefix to look for those

ELFs, and make sure the test suite can find them (ie, appending the path

to os.environ['PATH']).


Yolkfull, please take a look at implementing those suggestions.


Thanks again for your work!


Lucas


--
[view original message]
From: Yolkfull Chow <yzhou@...>
To: Lucas Meneghel Rodrigues <lmr@...>
Cc: <autotest@...>, <kvm@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Friday, July 3, 2009 - 5:18 am

Lucas, do we really need to find those ELFs within the whole disk if

they are not in os.environ['PATH']?  That's not testsuite's purpose I

think.


--

Yolkfull

Regards,


--
[view original message]
From: Lucas Meneghel Rodrigues <lmr@...>
To: Yolkfull Chow <yzhou@...>
Cc: <autotest@...>, <kvm@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Friday, July 3, 2009 - 8:37 am

Sure it's not. My point was just to allow the user to provide an

additional path (say self.srcdir or something like that) that could be

added to the environmental variable PATH. This would be useful if we

build/install the ELFs under a non standard location on a previous test.

No need to walk through the entire filesystem to find the binaries.


--
[view original message]
From: Yolkfull Chow <yzhou@...>
To: Lucas Meneghel Rodrigues <lmr@...>
Cc: <autotest@...>, <kvm@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Friday, July 3, 2009 - 1:11 am

Lucas, OK, I really forgot to set the PATH of 'qemu', 'qemu-img' and

'qemu-io'. I will do modifications according to your wonderful suggestions.


Thank you so much! :-)


--

Yolkfull

Regards,


--
[view original message]
From: Yolkfull Chow <yzhou@...>
To: Lucas Meneghel Rodrigues <lmr@...>
Cc: <autotest@...>, sudhir kumar <smalikphy@...>, <kvm@...>, Martin Bligh <mbligh@...>
Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests
Date: Thursday, July 2, 2009 - 10:01 pm

I had compiled upstream qemu codes and run this test based on it, worked 


--

Yolkfull

Regards,


--
Previous thread: KVM: PIT: fix kpit_elapsed division by zero by Marcelo Tosatti on Thursday, July 2, 2009 - 7:02 pm. (2 messages)

Next thread: KVM-87 Compile warnings on 64-bit Jaunty by Randy Smith on Friday, July 3, 2009 - 12:38 am. (1 message)