Marcelo Tosatti wrote:
quoted text
> On Mon, May 18, 2009 at 09:26:31AM -0500, Anthony Liguori wrote:
>   
>> Marcelo Tosatti wrote:
>>     
>>> On Sun, May 17, 2009 at 07:59:51PM +0300, Avi Kivity wrote:
>>>   
>>>       
>>>> Anthony Liguori wrote:
>>>>     
>>>>         
>>>>> From: Yaniv Kamay <yaniv@qumranet.com>
>>>>>
>>>>> Stop cpus before devices when stopping the VM, start cpus after devices
>>>>> when starting VM.  Otherwise a vcpu could access a stopped device.
>>>>>
>>>>>         
>>>>>           
>>>> IIRC we decided this was unnecessary since everything is under   
>>>> qemu_mutex.  However we might want to be on the safe side here and be 
>>>>  similar to master.
>>>>     
>>>>         
>>> Yes, it is not necessary. Since upstream is already on the safe side
>>> (and the plan is to merge with it), IMO better leave this patch out.
>>>   
>>>       
>> Maybe it ought to be reverted from master then?
>>     
>
> Nope, its likelt to be useful in the future.
>   

If we change the locking, we'll likely need to change this.  In any case 
I don't like start/stop; I prefer explicit locking.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html