Home » Mailing list archives » linux-kvm » 2009 » May » 17

[PATCH 15/17] Fix loading extboot option rom

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Anthony Liguori
Subject: [PATCH 15/17] Fix loading extboot option rom
Date: Sunday, May 17, 2009 - 8:43 am

From: Avi Kivity <avi@redhat.com>

The buffer that is used to store the extboot filename is later overwritten
by the vga rom loading code.  Use strdup() to keep our filename.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

diff --git a/hw/pc.c b/hw/pc.c
index d6486a1..626450c 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -944,7 +944,7 @@ vga_bios_error:
 
     if (extboot_drive != -1) {
 	snprintf(buf, sizeof(buf), "%s/%s", bios_dir, EXTBOOT_FILENAME);
-        option_rom[nb_option_roms++] = buf;
+        option_rom[nb_option_roms++] = strdup(buf);
     }
 
     {
-- 
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 01/17] kvm: libkvm: protect irq injection status co ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 02/17] kvm: testsuite: compile fix - avoid raw stri ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 03/17] Fix build breakage on non-device-deassignmen ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 04/17] kvm: extboot: Update number of HDs reported ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 05/17] Stop/start cpus before/after devices, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 06/17] Use statfs to determine size of huge pages, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 07/17] Fixup 4GB+ memslot large page alignment, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 08/17] Clear tap features on initialization, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 09/17] Propagate errors on failed migration., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 10/17] Support unregistering memory regions larger ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 11/17] net: drop packet from tap device if all NICs ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 11/17] net: drop packet from tap device if all NICs ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 12/17] Increment virtio-net savevm version to avoid ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 13/17] Increment version id for CPU save state, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 14/17] Fix build when objdir != srcdir, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 15/17] Fix loading extboot option rom, Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 16/17] virtio-net: Make save/load format independen ..., Anthony Liguori, (Sun May 17, 8:43 am)
[PATCH 17/17] virtio-net: Refuse loading if the source req ..., Anthony Liguori, (Sun May 17, 8:43 am)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Avi Kivity, (Sun May 17, 9:56 am)
Re: [PATCH 01/17] kvm: libkvm: protect irq injection statu ..., Avi Kivity, (Sun May 17, 9:57 am)
Re: [PATCH 03/17] Fix build breakage on non-device-deassig ..., Avi Kivity, (Sun May 17, 9:58 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Avi Kivity, (Sun May 17, 9:59 am)
Re: [PATCH 06/17] Use statfs to determine size of huge pages, Avi Kivity, (Sun May 17, 10:00 am)
Re: [PATCH 10/17] Support unregistering memory regions lar ..., Avi Kivity, (Sun May 17, 10:03 am)
Re: [PATCH 12/17] Increment virtio-net savevm version to a ..., Avi Kivity, (Sun May 17, 10:04 am)
Re: [PATCH 13/17] Increment version id for CPU save state, Avi Kivity, (Sun May 17, 10:06 am)
Re: [PATCH 15/17] Fix loading extboot option rom, Avi Kivity, (Sun May 17, 10:06 am)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Avi Kivity, (Sun May 17, 10:10 am)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Anthony Liguori, (Sun May 17, 4:32 pm)
Re: [PATCH 12/17] Increment virtio-net savevm version to a ..., Anthony Liguori, (Sun May 17, 4:33 pm)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Anthony Liguori, (Sun May 17, 4:36 pm)
Re: [PATCH 12/17] Increment virtio-net savevm version to a ..., Avi Kivity, (Sun May 17, 4:41 pm)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Avi Kivity, (Sun May 17, 4:46 pm)
Re: [PATCH 06/17] Use statfs to determine size of huge pages, Joerg Roedel, (Mon May 18, 2:02 am)
Re: [PATCH 06/17] Use statfs to determine size of huge pages, Anthony Liguori, (Mon May 18, 6:10 am)
Re: [PATCH 06/17] Use statfs to determine size of huge pages, Joerg Roedel, (Mon May 18, 6:22 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Marcelo Tosatti, (Mon May 18, 6:58 am)
Re: [PATCH 10/17] Support unregistering memory regions lar ..., Jan Kiszka, (Mon May 18, 7:23 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Anthony Liguori, (Mon May 18, 7:26 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Avi Kivity, (Mon May 18, 7:46 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Marcelo Tosatti, (Mon May 18, 7:47 am)
Re: [PATCH 05/17] Stop/start cpus before/after devices, Avi Kivity, (Mon May 18, 7:55 am)
Re: [PATCH 11/17] net: drop packet from tap device if all ..., Mark McLoughlin, (Tue May 19, 10:52 am)
Re: [PATCH 0/17][REVIEW] Backport candidates for stable-0.10, Avi Kivity, (Thu May 21, 2:06 am)